Skip to content

Data download is completely broken by CMC's v1 API Deprecation #86

@ddm-j

Description

@ddm-j

This is a(n):

  • New feature
  • Update to an existing feature
  • Error
  • Proposal to the Repository

Details:
CoinMarketCap (CMC) seems to have recently deprecated some of their V1 endpoints, which this library depends on.

In utils.py we have the core downloading logic accessing the following endpoints:

    if id_number:
        api_url = "https://web-api.coinmarketcap.com/v1/cryptocurrency/ohlcv/historical?convert={}&id={}&time_end={}&time_start={}".format(
            fiat, id_number, end_date_timestamp, start_date_timestamp
        )
    else:
        api_url = "https://web-api.coinmarketcap.com/v1/cryptocurrency/ohlcv/historical?convert={}&slug={}&time_end={}&time_start={}".format(
            fiat, coin_id, end_date_timestamp, start_date_timestamp
        )

CMC now requires an API key for this, and gives a different response than the code downstream in core.py's _download_data method expects:

Error message (download_data) : Expecting value: line 1 column 1 (char 0)

Unless I'm completely wrong, CMC's API change may make this library completely obsolete, which is sad.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions