resource/refreshAfterApply: remove extra refresh#628
Merged
austinvalle merged 2 commits intohashicorp:mainfrom Mar 4, 2026
Merged
resource/refreshAfterApply: remove extra refresh#628austinvalle merged 2 commits intohashicorp:mainfrom
resource/refreshAfterApply: remove extra refresh#628austinvalle merged 2 commits intohashicorp:mainfrom
Conversation
austinvalle
approved these changes
Mar 4, 2026
Member
austinvalle
left a comment
austinvalle
left a comment
There was a problem hiding this comment.
I pushed a change (79680fb) to remove the changelog related to this portion of the originally proposed change in #602
LGTM since we’re just reverting part of the originally proposed change in #602. Our CI doesn't run on forks still 🙁 , but I ran them locally against this PR and everything looks good 🚀
Member
|
I'll need another approval from someone else in @hashicorp/terraform-core-plugins since I pushed a commit removing that changelog 😄 |
SBGoods
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
This fixes mismatching in VCR tests when running CI on GCP PRs.
We run into a
requested interaction not founddue to the extra refresh resulting in two GET requests. This leads to a mismatch in the RECORDED cassette and REPLAYED cassete (REPLAYED as in the PR which introduces the bump to the latestplugin-testingPR)Would fix build errors occuring on the
plugin-testingbump: GoogleCloudPlatform/magic-modules#16369 (comment)Description
In plain English, describe your approach to addressing the issue linked above. For example, if you made a particular design decision, let us know why you chose this path instead of another solution.
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.