fix: use correct default header prefix for standard webhook mode (#665)

* chore: make nuke/deps

* fix: use correct default header prefix for standard webhook mode

Author: alexluong

Makefile

@@ -59,6 +59,9 @@ up/deps:
 down/deps:
 	COMPOSE_PROFILES=$$(./build/dev/deps/profiles.sh --all) docker-compose -f build/dev/deps/compose.yml -f build/dev/deps/compose-gui.yml down
 
+nuke/deps:
+	COMPOSE_PROFILES=$$(docker compose -f build/dev/deps/compose.yml -f build/dev/deps/compose-gui.yml config --profiles | paste -sd, -) docker compose -f build/dev/deps/compose.yml -f build/dev/deps/compose-gui.yml down --volumes --remove-orphans
+
 up/mqs:
 	docker-compose -f build/dev/mqs/compose.yml up -d
 

internal/config/config.go

@@ -178,7 +178,6 @@ func (c *Config) InitDefaults() {
 	c.Destinations = DestinationsConfig{
 		MetadataPath: "config/outpost/destinations",
 		Webhook: DestinationWebhookConfig{
-			HeaderPrefix:             "x-outpost-",
 			SignatureContentTemplate: "{{.Body}}",
 			SignatureHeaderTemplate:  "v0={{.Signatures | join \",\"}}",
 			SignatureEncoding:        "hex",

internal/config/config_test.go

@@ -71,7 +71,7 @@ func TestDefaultValues(t *testing.T) {
 	assert.Equal(t, "config/outpost/destinations", cfg.Destinations.MetadataPath)
 	assert.Equal(t, 10, cfg.LogBatchThresholdSeconds)
 	assert.Equal(t, 1000, cfg.LogBatchSize)
-	assert.Equal(t, "x-outpost-", cfg.Destinations.Webhook.HeaderPrefix)
+	assert.Equal(t, "", cfg.Destinations.Webhook.HeaderPrefix)
 }
 
 func TestYAMLConfig(t *testing.T) {
@@ -328,7 +328,7 @@ func TestDestinationConfig(t *testing.T) {
 			name:    "default header prefix",
 			files:   map[string][]byte{},
 			envVars: map[string]string{},
-			want:    "x-outpost-",
+			want:    "",
 		},
 		{
 			name: "yaml config header prefix",

internal/destregistry/providers/destwebhook/destwebhook.go

@@ -116,7 +116,9 @@ type Option func(*WebhookDestination)
 // WithHeaderPrefix sets a custom prefix for webhook request headers
 func WithHeaderPrefix(prefix string) Option {
 	return func(w *WebhookDestination) {
-		w.headerPrefix = prefix
+		if prefix != "" {
+			w.headerPrefix = prefix
+		}
 	}
 }