Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

Add dependency on mDNS rather than bundling it #20

@tomasz-wiszkowski

Description

@tomasz-wiszkowski

Hello! Thank you for putting this library together!

I noticed that the library bundles in ESP8266mDNS dependency, rather than requesting it to be installed separately at specific version.

the outcome is that any project that would depend on both mDNS and notifier spots and reports a conflict that cannot be easily resolved.

It would be great if the library used __has_include feature (confirmed to work) (https://en.cppreference.com/w/cpp/feature_test) to report missing dependency, eg.

#ifdef __has_include
#  if !__has_include(<ESP8266mDNS.h>)
#    error Please use package manager to install ESP8266mDNS at version X
#  endif
#endif

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions