Skip to content

Commit 43c0c62

Browse files
committed
Only use ModelGroup.details if python-ihm supports it
1 parent 65a7f80 commit 43c0c62

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

modelcif/dumper.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -641,7 +641,10 @@ def dump_model_groups(self, system, writer):
641641
def dump_model_group_summary(self, system, writer):
642642
with writer.loop("_ma_model_group", ["id", "name", "details"]) as lp:
643643
for group in system.model_groups:
644-
lp.write(id=group._id, name=group.name, details=group.details)
644+
# ihm.model.ModelGroup only supports details after v1.8
645+
lp.write(id=group._id, name=group.name,
646+
details=group.details
647+
if hasattr(group, 'details') else None)
645648

646649
def dump_model_group_link(self, system, writer):
647650
with writer.loop("_ma_model_group_link",

test/test_dumper.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -434,8 +434,9 @@ class CustomModel(modelcif.model.Model):
434434
system.model_groups.append(mg)
435435
# model1 is in both groups
436436
mg = modelcif.model.ModelGroup((model1,),
437-
name='second group',
438-
details='second group details')
437+
name='second group')
438+
# ModelGroup constructor only supports details with python-ihm > 1.8
439+
mg.details = 'second group details'
439440
system.model_groups.append(mg)
440441
dumper = modelcif.dumper._ModelDumper()
441442
dumper.finalize(system)

0 commit comments

Comments
 (0)