polish changes page

- review changes
- Inspect page: add link to history of current object

Author: brainexe

serveradmin/serverdb/templates/serverdb/changes.html

@@ -94,6 +94,7 @@ <h3>
                 <label for="attribute" class="col-sm-1 col-form-label">Attribute:</label>
                 <div class="col-md-4">
                     <input name="attribute" id="attribute" type="text" value="{% if attribute %}{{ attribute }}{% endif %}" class="form-control form-control-sm" placeholder="responsible_admin" />
+                    <small class="form-text text-muted">Requires hostname, object ID, or user/app filter</small>
                 </div>
             </div>
             <div class="form-group row input-controls buttons">

serveradmin/serverdb/templatetags/changes.py

@@ -23,17 +23,6 @@ def hostname(object_id: int) -> Union[str, int]:
         return object_id
 
 
-def _format_value(value: Any) -> str:
-    """Format a value for display, handling None/empty as '-'."""
-    if value is None or value == '':
-        return '-'
-    if isinstance(value, list):
-        return ', '.join(str(v) for v in value)
-    if isinstance(value, set):
-        return ', '.join(str(v) for v in sorted(value))
-    return str(value)
-
-
 @register.filter
 def get_attribute_changes(change: Change) -> list:
     """Extract attribute changes from a Change object's change_json.
@@ -46,14 +35,14 @@ def get_attribute_changes(change: Change) -> list:
 
     changes_list = []
 
-    for attr_name, attr_change in change.change_json.items():
-        if attr_name == 'object_id' or not isinstance(attr_change, dict):
+    for attribute_id, attr_change in change.change_json.items():
+        if attribute_id == 'object_id' or not isinstance(attr_change, dict):
             continue
 
-        prefix = f'<strong>{escape(attr_name)}:</strong>'
+        prefix = f'<strong>{attribute_id}:</strong>'
         action = attr_change.get('action')
-        old_val = escape(_format_value(attr_change.get('old')))
-        new_val = escape(_format_value(attr_change.get('new')))
+        old_val = escape(attr_change.get('old'))
+        new_val = escape(attr_change.get('new'))
 
         if action == 'update':
             if attr_change.get('new') in (None, ''):

serveradmin/serverdb/views.py

@@ -68,7 +68,11 @@ def changes(request):
 
     f_attribute = request.GET.get('attribute')
     if f_attribute:
-        commits = commits.filter(change__change_json__has_key=f_attribute)
+        # Only allow attribute filter if another filter is set (no index)
+        if f_hostname or f_object_id or f_user_or_app:
+            commits = commits.filter(change__change_json__has_key=f_attribute)
+        else:
+            f_attribute = None
 
     commits = commits.select_related('app', 'user')
 

serveradmin/servershell/templates/servershell/inspect.html

@@ -26,6 +26,7 @@ <h3>
     <div class="col-md-8">
         <a class="btn btn-success" data-edit-link href="{% url 'servershell_edit' %}?object_id={{ object_id }}">Edit</a>
         <a href="{% url 'servershell_index' %}" class="btn btn-success">Goto Servershell</a>
+        <a href="/serverdb/changes?object_id={{ object_id }}" class="btn btn-success">History</a>
     </div>
 </div>
 <div class="row mb-3">
@@ -72,6 +73,7 @@ <h3>
     <div class="col-md-8">
         <a class="btn btn-success" data-edit-link href="{% url 'servershell_edit' %}?object_id={{ object_id }}">Edit</a>
         <a href="{% url 'servershell_index' %}" class="btn btn-success">Goto Servershell</a>
+        <a href="/serverdb/changes?object_id={{ object_id }}" class="btn btn-success">History</a>
     </div>
 </div>
 </div>