Stop ignoring import clauses in non-unit files

Previously there were concerns over breaking IDE features by formatting
these sections, but after some testing and reconsideration we have
decided that this is a non-issue and it's better to consistently format
all import clauses.

In `program` files (dpr) RAD Studio will sometimes store some metadata in special
comments adjacent to the imports in the `uses` clause. This is
apparently an artifact of a time before Delphi had dproj files, where it
would indicate whether a unit contains a form only using the comment.
Various IDE features depend on 'knowing' what forms are available and
what their names are, including
1. opening the form when you open the unit
2. showing the form in the project overview panel
3. being able to inherit from the form using the IDE dialogs
4. being able to open a frame contained within a form

In modern Delphi, the IDE also reads the dproj to find out about the
contained forms, and in such cases doesn't need the comment at all.

What about when it needs to read the comment? Does the formatting break
that feature? It doesn't appear that it does. `pasfmt` only changes two
things when formatting the uses clause in a dpr file when compared to
what the IDE generates.
1. `{$ifdef}` directives are moved all the way left to the margin, and
2. if a unit name is really long, then the `in '...'` part of the
   import is wrapped to the next line.

In our testing all the IDE features continue to work when the dproj
doesn't contain the information about the form and the uses clause is
formatted by `pasfmt`.

A secondary concern to the breakage of form features was the fact that
we would be 'fighting' against the formatting that the IDE generates. On
reconsideration, this doesn't seem like a compelling reason to skip
formatting these sections. It's highly unintuitive that the formatter
skips formatting these sections, and it's undesirable when the user is
writing actual code in the program file, because they will be manually
adding to the import clause for the units they need, and they can't make
the formatter format the changes they are making.

There will inevitably be some level of flip-flopping of formatting, but
if one cares about having all their source files automatically formatted
they should have some other process ensuring that is the case.
Additionally, this flip-flopping is limited to conditional directives
and wrapped `in` expressions, because the style `pasfmt` uses (with
default whitespace configuration) is very similar to the style generated
by the IDE.

In the case of dpk files, we may well make an exception and change our
formatting style for the conditional directives for the `IMPLICITBUILD`
block (see #166), because the file is completely generated and it's
guaranteed to affect every dpk file.

This PR should supersede #200.

Author: zaneduffield

CHANGELOG.md

@@ -7,9 +7,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## [Unreleased]
 
-### Fixed
+### Changed
 
-- Fixed conditional directives not being ignored between `uses` and import list in non-units.
+- Uses, contains, and requires clauses in `program`, `package`, and `library` files are no longer ignored.
+  Previously there were concerns over breaking IDE features by formatting these sections, but after some
+  testing and reconsideration we have decided that this is a non-issue and it's better to consistently
+  format all import clauses.
 
 ## [0.4.0-rc2] - 2025-03-12
 

core/CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Removed
+
+- Removed `IgnoreNonUnitImportClauses`; all import clauses are now formatted.
+
 ## [0.4.0-rc2] - 2025-03-12
 
 ### Changed

core/src/rules/ignore_non_unit_import_clauses.rs

@@ -3,7 +3,6 @@ pub mod eof_newline;
 pub mod formatting_toggle;
 pub mod generics_consolidator;
 pub mod ignore_asm_instructions;
-pub mod ignore_non_unit_import_clauses;
 pub mod optimising_line_formatter;
 pub mod token_spacing;
 
@@ -12,6 +11,5 @@ pub use eof_newline::*;
 pub use formatting_toggle::*;
 pub use generics_consolidator::*;
 pub use ignore_asm_instructions::*;
-pub use ignore_non_unit_import_clauses::*;
 pub use optimising_line_formatter::*;
 pub use token_spacing::*;

core/src/rules/mod.rs

@@ -305,7 +305,6 @@ pub fn make_formatter(config: &FormattingConfig) -> Formatter {
         .token_consolidator(DistinguishGenericTypeParamsConsolidator {})
         .lines_consolidator(ConditionalDirectiveConsolidator {})
         .token_ignorer(FormattingToggler {})
-        .token_ignorer(IgnoreNonUnitImportClauses {})
         .token_ignorer(IgnoreAsmIstructions {})
         .file_formatter(TokenSpacing {})
         .line_formatter(FormatterSelector::new(