Skip to content

Commit d31dbb9

Browse files
authored
[libc][wctype] Move classification lookup tables to a cpp file (#174993)
#170525 Previously, lookup tables were defined in a header so that they can be constexpr, but this lead to each translation unit having it's own copy, bloating the library size. Looking at current usages of wctype functions, they are always used at runtime, so there's no benefit of having them constexpr, so I'm moving them to a cpp file, so that there's only a single copy in the library.
1 parent a76f638 commit d31dbb9

File tree

4 files changed

+3749
-3697
lines changed

4 files changed

+3749
-3697
lines changed

libc/src/__support/wctype/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1-
add_header_library(
1+
add_object_library(
22
wctype_classification_utils
33
HDRS
44
wctype_classification_utils.h
5+
SRCS
6+
wctype_classification_utils.cpp
57
DEPENDS
68
libc.hdr.types.wchar_t
79
libc.hdr.stdint_proxy

0 commit comments

Comments
 (0)