Skip to content

Comments

feat: fallback to loading when encountering proxy timeout#1511

Open
dhhyi wants to merge 2 commits intodevelopfrom
feat/fallback-loading-when-timeout-2
Open

feat: fallback to loading when encountering proxy timeout#1511
dhhyi wants to merge 2 commits intodevelopfrom
feat/fallback-loading-when-timeout-2

Conversation

@dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Sep 22, 2023

PR Type

[x] Feature

What Is the Current Behavior?

High loads on SSR (as well as improper configuration or technical debt) can exhaust all rendering processes and users get long loading times or timeouts.

What Is the New Behavior?

If a timeout is encountered, the loading page will be sent to the user so that Angular can boot up on the client. This does not give the user a full page response, but he can use the webshop. Meanwhile the nginx waits for rendering to finish and caches the page.

replaces #1477

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

TODO/Discussion

  • make timeout configurable
  • apply loading fallback only to browser clients
  • documentation

Other Information

AB#89692

@dhhyi dhhyi added research Exploration for fancy new stuff nice to have Something that we can all live without, but will really improve a certain unimportant aspect performance Performance improvements labels Sep 22, 2023
@dhhyi dhhyi self-assigned this Sep 22, 2023
@dhhyi dhhyi force-pushed the feat/fallback-loading-when-timeout-2 branch from 86ace9d to 2e12e9c Compare September 25, 2023 07:07
@dhhyi dhhyi force-pushed the feat/fallback-loading-when-timeout-2 branch from 2e12e9c to 879b600 Compare September 25, 2023 07:08
@dhhyi dhhyi force-pushed the feat/fallback-loading-when-timeout-2 branch from 879b600 to 82a3956 Compare September 25, 2023 08:14
@dhhyi dhhyi marked this pull request as ready for review September 25, 2023 14:26
@dhhyi dhhyi force-pushed the feat/fallback-loading-when-timeout-2 branch from 82a3956 to 25907bd Compare October 2, 2023 08:22
@dhhyi dhhyi removed their assignment Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has conflicts nice to have Something that we can all live without, but will really improve a certain unimportant aspect performance Performance improvements research Exploration for fancy new stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant