generated from ipfs/ipfs-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 150
Open
Labels
P3Low: Not priority right nowLow: Not priority right nowdif/mediumPrior experience is likely helpfulPrior experience is likely helpfuleffort/hoursEstimated to take one or several hoursEstimated to take one or several hourskind/enhancementA net-new feature or improvement to an existing featureA net-new feature or improvement to an existing featuretopic/devexpDeveloper experience related thingsDeveloper experience related things
Description
The current declaration of Keystore's List() ([]string, error) doesn't take any arguments and returns the whole list of keys per one output. I suggest making it a line-buffered stream.
Lines 31 to 32 in c9cb61d
| // List returns a list of key identifier | |
| List() ([]string, error) |
My use case comes from ipfs/kubo#11102 (comment):
Currently the key listing accumulates all the keys and outputs them to terminal in one write.
I think, it would be better to output line-buffered stream of keys to the terminal.
It's related because the case is the same: generating keys in batches.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P3Low: Not priority right nowLow: Not priority right nowdif/mediumPrior experience is likely helpfulPrior experience is likely helpfuleffort/hoursEstimated to take one or several hoursEstimated to take one or several hourskind/enhancementA net-new feature or improvement to an existing featureA net-new feature or improvement to an existing featuretopic/devexpDeveloper experience related thingsDeveloper experience related things