Remove nonsense

Author: jamescook

bin/rubocop-interactive

@@ -77,8 +77,5 @@ OptionParser.new do |opts|
 end.parse!
 
 # Start interactive session - loading screen shown before reading input
-if ARGV.any?
-  RubocopInteractive.start_with_files!(ARGV, **options)
-else
-  RubocopInteractive.start_with_stdin!(**options)
-end
+input = ARGV.any? ? ARGV : $stdin
+RubocopInteractive.start!(input, **options)

lib/rubocop_interactive.rb

@@ -20,28 +20,33 @@
 module RubocopInteractive
   class Error < StandardError; end
 
-  def self.start_with_stdin!(confirm_patch: false, template: 'default', summary_on_exit: false, record_keypresses: false)
-    ui = UI.new(confirm_patch: confirm_patch, template: template, summary_on_exit: summary_on_exit, record_keypresses: record_keypresses)
-    ui.show_loading(source: :stdin)
-
-    json = $stdin.read
-
-    start!(json, ui: ui, confirm_patch: confirm_patch, template: template, summary_on_exit: summary_on_exit, record_keypresses: record_keypresses)
-  end
-
-  def self.start_with_files!(files, confirm_patch: false, template: 'default', summary_on_exit: false, record_keypresses: false)
-    ui = UI.new(confirm_patch: confirm_patch, template: template, summary_on_exit: summary_on_exit, record_keypresses: record_keypresses)
-    ui.show_loading(source: :files, files: files)
-
-    json = run_rubocop_on_files(files)
-
-    start!(json, ui: ui, confirm_patch: confirm_patch, template: template, summary_on_exit: summary_on_exit, record_keypresses: record_keypresses)
-  end
-
-  def self.start!(json, ui: nil, confirm_patch: false, template: 'default', summary_on_exit: false, record_keypresses: false)
+  def self.start!(input, ui: nil, confirm_patch: false, template: 'default', summary_on_exit: false, record_keypresses: false)
+    # Create UI if not provided
     ui ||= UI.new(confirm_patch: confirm_patch, template: template, summary_on_exit: summary_on_exit, record_keypresses: record_keypresses)
 
-    session = Session.new(json, ui: ui)
+    # Convert input to JSON string based on type
+    json_string = case input
+                  when Array
+                    # Array of file paths
+                    ui.show_loading(source: :files, files: input)
+                    run_rubocop_on_files(input)
+                  when Hash
+                    # Already parsed JSON - convert back to string
+                    JSON.generate(input)
+                  when String
+                    # Raw JSON string
+                    input
+                  else
+                    # IO-like object (IO, StringIO, File, etc) - must have #read method
+                    if input.respond_to?(:read)
+                      ui.show_loading(source: :stdin)
+                      input.read
+                    else
+                      raise ArgumentError, "input must be IO-like (with #read), Array (files), Hash (parsed JSON), or String (JSON)"
+                    end
+                  end
+
+    session = Session.new(json_string, ui: ui)
     stats = session.run
 
     # Write keypress recording if enabled

test/e2e/calculator_test.rb

@@ -184,23 +184,7 @@ def run_sample
   end
 
   def run_rubocop_json
-    require 'rubocop'
-    require 'stringio'
-
-    output = StringIO.new
-    old_stdout = $stdout
-    old_stderr = $stderr
-    $stdout = output
-    $stderr = StringIO.new
-
-    begin
-      cli = RuboCop::CLI.new
-      cli.run(['--format', 'json', '--cache', 'false', @work_file])
-    ensure
-      $stdout = old_stdout
-      $stderr = old_stderr
-    end
-
-    JSON.parse(output.string)
+    json_string = RubocopInteractive.run_rubocop_on_files([@work_file])
+    JSON.parse(json_string)
   end
 end

test/support/fakes.rb

@@ -10,6 +10,10 @@ def initialize(responses: [])
     @offenses_shown = []
   end
 
+  def show_loading(source:, files: nil)
+    # no-op
+  end
+
   def show_summary(total:)
     # no-op
   end