addition of integration test case

Author: jens18

.travis.yml

@@ -1,5 +1,6 @@
 language: go
 
+# request VM instead of container (default)
 sudo: required 
 dist: trusty
 
@@ -17,16 +18,17 @@ before_install:
   - go get github.com/gorilla/mux
   - go get golang.org/x/tools/cmd/cover
   - go get github.com/mattn/goveralls
+  # create virtual CANBus interface vcan0 
+  - sudo modprobe vcan
+  - sudo ip link add dev vcan0 type vcan
+  - sudo ip link set up vcan0
+  - ifconfig vcan0
 
 script:
   - go test -v -covermode=count -coverprofile=coverage.out -tags test ./... 
   # upload coverage.out report
   - $HOME/gopath/bin/goveralls -coverprofile=coverage.out -service=travis-ci -repotoken $COVERALLS_TOKEN
-  - sudo modprobe vcan
-  - sudo ip link add dev vcan0 type vcan
-  - sudo ip link set up vcan0
-  - ifconfig vcan0
-  - make install
+  - export GOARCH=arm; make install
 
 deploy:
   provider: releases

cmd/lgresu_mon/lgresu_mon_test.go

@@ -19,8 +19,12 @@ import (
 	"github.com/brutella/can"
 	rs "github.com/jens18/lgresu/lgresustatus"
 	log "github.com/sirupsen/logrus"
+	"io/ioutil"
+	"net"
 	"net/http"
 	"net/http/httptest"
+	"os/exec"
+	"syscall"
 	"testing"
 	"time"
 )
@@ -48,9 +52,77 @@ func (c *MockCanbus) Disconnect() error {
 	return nil
 }
 
+// canbusTestMessages contains test messages generated by the LG Resu 10 LV battery BMS
+var canbusTestMessages = []struct {
+	Identifier uint32
+	Data       [8]byte
+}{
+	// volt/amp/temp (LG Resu -> Inverter):
+	{
+		Identifier: rs.BMS_VOLT_AMP_TEMP,
+		Data:       [8]byte{0x4b, 0x15, 0xed, 0xff, 0xba, 0x00, 0x00, 0x00},
+	},
+	// ? (LG Resu -> Inverter): unknown message type (appears to be a constant)
+	{
+		Identifier: rs.BMS_SERIAL_NUM,
+		Data:       [8]byte{0x04, 0xc0, 0x00, 0x1f, 0x03, 0x00, 0x00, 0x00},
+	},
+	// configuration parameters (LG Resu -> Inverter):
+	{
+		Identifier: rs.BMS_LIMITS,
+		Data:       [8]byte{0x41, 0x02, 0x96, 0x03, 0x96, 0x03, 0x00, 0x00},
+	},
+	// state of charge/health (LG Resu -> Inverter):
+	{
+		Identifier: rs.BMS_SOC_SOH,
+		Data:       [8]byte{0x4d, 0x00, 0x63, 0x00, 0x00, 0x00, 0x00, 0x00},
+	},
+	// warnings/alarms (LG Resu -> Inverter):
+	{
+		Identifier: rs.BMS_WARN_ALARM,
+		Data:       [8]byte{0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00},
+	},
+}
+
+func sendCanbusMessages(ifName string) {
+	iface, err := net.InterfaceByName(ifName)
+
+	if err != nil {
+		log.Fatalf("sendCanbusMessages(): Could not find network interface %s (%v) \n", ifName, err)
+	}
+
+	// bind to socket
+	conn, err := can.NewReadWriteCloserForInterface(iface)
+
+	if err != nil {
+		log.Fatalf("sendCanbusMessages(): Could not bind to socket %v \n", err)
+	}
+
+	bus := can.NewBus(conn)
+
+	f := can.Frame{}
+
+	for {
+		// send all LG Resu 10 test messages in one block
+		for _, tm := range canbusTestMessages {
+
+			f.ID = tm.Identifier
+			f.Length = uint8(len(tm.Data))
+			f.Data = tm.Data
+
+			bus.Publish(f)
+
+			log.Debugf("%#4x # % -24X \n", tm.Identifier, tm.Data)
+		}
+
+		// wait for 1 second
+		<-time.After(time.Second * 1)
+	}
+}
+
 func init() {
 	// only log warning severity or above.
-	log.SetLevel(log.DebugLevel)
+	log.SetLevel(log.WarnLevel)
 }
 
 // https://blog.questionable.services/article/testing-http-handlers-go/
@@ -137,8 +209,6 @@ func TestWriteRecord(t *testing.T) {
 
 	time.Sleep(3 * time.Second)
 
-	t.Logf("dataRecorder invocations: %d \n", dataRecorder.Cnt)
-
 	if dataRecorder.Cnt != 2 {
 		t.Errorf("writeRecorder() requested %d lgResu objects, expect %d requests \n",
 			dataRecorder.Cnt, 2)
@@ -197,7 +267,7 @@ func TestDecodeCanFrame(t *testing.T) {
 
 	lgResu := rs.LgResuStatus{}
 	lgResu = <-recordEmitChan
-	t.Logf("lgResu.Soc = %d\n", lgResu.Soc)
+
 	if lgResu.Soc != 77 {
 		t.Errorf("decodeCanFrame() produce Soc = %d, expect Soc = 77 \n",
 			lgResu.Soc)
@@ -243,3 +313,51 @@ func TestBrokerRecord(t *testing.T) {
 			lgResuWrite.Soc)
 	}
 }
+
+// TestIntegration tests if the HTTP request returns a JSON object.
+func TestIntegration(t *testing.T) {
+
+	// start lgresu_mon server, combine stdout and stderr
+	cmd := exec.Command("sh", "-c",
+		"go run lgresu_mon.go lgresu_actors.go -if vcan0 -d debug -p 9090 -dr data -r 7 > lg_resu_mon.log 2>&1")
+	// https://medium.com/@felixge/killing-a-child-process-and-all-of-its-children-in-go-54079af94773
+	cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
+
+	// start in background
+	err := cmd.Start()
+	if err != nil {
+		log.Fatal(err)
+	}
+
+	// generate CANBus messages
+	go sendCanbusMessages("vcan0")
+
+	// time to startup lg_resu_mon server
+	time.Sleep(3 * time.Second)
+
+	// HTTP request
+	resp, err := http.Get("http://localhost:9090")
+	if err != nil {
+		t.Log(err) // handle error
+	}
+	defer resp.Body.Close()
+	body, err := ioutil.ReadAll(resp.Body)
+
+	log.Debugf("body = %s \n", body)
+
+	// re-constructed lgResuStatus message
+	var status rs.LgResuStatus
+	err = json.Unmarshal(body, &status)
+	if err != nil {
+		t.Error(err)
+	}
+
+	// test Soc received against Soc send
+	if status.Soc != 77 {
+		t.Errorf("Index handler() returned Soc value %v, expect Soc value %v \n",
+			status.Soc, 77)
+	}
+
+	// stop process when test is complete
+	syscall.Kill(-cmd.Process.Pid, syscall.SIGKILL)
+}

lgresustatus/lgresustatus_test.go

@@ -138,7 +138,7 @@ func TestCsvRecord(t *testing.T) {
 	timestamp, _ := time.Parse("2006-Jan-02", "2018-Jun-11")
 
 	csvRecord := lgResu.CsvRecord(timestamp)
-	t.Log(csvRecord)
+	log.Debugf("TestCsvRecord: csvRecord = %s \n", csvRecord)
 
 	csvHeader := CsvRecordHeader()