[cr] fix pylint errors

Author: jewbetcha

pyproject.toml

@@ -53,8 +53,9 @@ build-backend = "hatchling.build"
 [tool.hatch.build.targets.wheel]
 packages = ["src/openlaunch"]
 
-[tool.uv]
-dev-dependencies = [
+[dependency-groups]
+dev = [
+    "pylint>=3.3.9",
     "pytest>=7.0.0",
     "ruff>=0.1.0",
 ]
@@ -67,6 +68,23 @@ target-version = "py39"
 select = ["E", "F", "W", "I"]
 ignore = ["E501"]  # Line length handled separately
 
+[tool.pylint.main]
+py-version = "3.9"
+
+[tool.pylint.messages_control]
+disable = [
+    "too-many-instance-attributes",  # Radar and monitor classes need many attributes
+    "too-many-public-methods",       # Radar API has many commands
+    "too-many-locals",               # Distance estimation lookup table
+    "too-many-statements",           # CLI main function
+    "import-outside-toplevel",       # argparse in main() is fine
+    "broad-exception-caught",        # Generic catch in streaming loop is intentional
+    "invalid-name",                  # Allow DRIVER_TABLE, CLUB_FACTORS constants
+]
+
+[tool.pylint.format]
+max-line-length = 100
+
 [tool.pytest.ini_options]
 testpaths = ["tests"]
 python_files = ["test_*.py"]

src/openlaunch/launch_monitor.py

@@ -12,7 +12,7 @@
 from datetime import datetime
 from enum import Enum
 
-from .ops243 import OPS243Radar, SpeedReading, Direction
+from .ops243 import OPS243Radar, SpeedReading
 
 
 class ClubType(Enum):
@@ -315,7 +315,7 @@ def _on_reading(self, reading: SpeedReading):
             min_speed = self.MIN_BALL_SPEED_MPH
 
         # Filter by realistic speeds
-        if not (min_speed <= reading.speed <= self.MAX_BALL_SPEED_MPH):
+        if not min_speed <= reading.speed <= self.MAX_BALL_SPEED_MPH:
             return
 
         # Check if this is part of current shot or new shot
@@ -369,9 +369,11 @@ def _process_shot(self):
             club_speed_tolerance = 20  # mph tolerance
 
             # Find readings that could be club (within expected range)
+            club_speed_min = expected_club_speed - club_speed_tolerance
+            club_speed_max = expected_club_speed + club_speed_tolerance
             potential_club_speeds = [
                 s for s in speeds
-                if (expected_club_speed - club_speed_tolerance) <= s <= (expected_club_speed + club_speed_tolerance)
+                if club_speed_min <= s <= club_speed_max
                 and s < peak_speed * 0.85  # Must be significantly less than ball speed
             ]
 
@@ -380,7 +382,7 @@ def _process_shot(self):
                 club_speed = max(potential_club_speeds)
 
                 # Validate: club speed should be realistic
-                if not (self.MIN_CLUB_SPEED_MPH <= club_speed <= self.MAX_CLUB_SPEED_MPH):
+                if not self.MIN_CLUB_SPEED_MPH <= club_speed <= self.MAX_CLUB_SPEED_MPH:
                     club_speed = None
 
         # Ball speed is the peak
@@ -508,7 +510,7 @@ def main():
                 print("Radar Configuration:")
                 for key, value in info.items():
                     print(f"  {key}: {value}")
-                return
+                return 0
 
             print("Ready! Swing when ready...")
             print("Press Ctrl+C to stop")
@@ -565,4 +567,5 @@ def on_live(reading):
 
 
 if __name__ == "__main__":
-    exit(main())
+    import sys
+    sys.exit(main())

src/openlaunch/ops243.py

@@ -17,14 +17,15 @@
 - 100kHz (SC): max 695 mph  - overkill but works
 """
 
-import serial
-import serial.tools.list_ports
 import json
-import time
 import threading
+import time
 from dataclasses import dataclass
-from typing import Optional, Callable, List
 from enum import Enum
+from typing import Callable, List, Optional
+
+import serial
+import serial.tools.list_ports
 
 
 class SpeedUnit(Enum):
@@ -156,7 +157,7 @@ def connect(self, timeout: float = DEFAULT_TIMEOUT) -> bool:
             self.serial.reset_input_buffer()
             return True
         except serial.SerialException as e:
-            raise ConnectionError(f"Failed to connect to {self.port}: {e}")
+            raise ConnectionError(f"Failed to connect to {self.port}: {e}") from e
 
     def disconnect(self):
         """Disconnect from the radar sensor."""
@@ -568,18 +569,17 @@ def _parse_reading(self, line: str) -> Optional[SpeedReading]:
                     timestamp=time.time(),
                     unit=self._unit
                 )
-            else:
-                # Plain number format
-                # Negative = inbound, positive = outbound
-                speed = float(line)
-                direction = Direction.OUTBOUND if speed > 0 else Direction.INBOUND
-
-                return SpeedReading(
-                    speed=abs(speed),
-                    direction=direction,
-                    timestamp=time.time(),
-                    unit=self._unit
-                )
+            # Plain number format
+            # Negative = inbound, positive = outbound
+            speed = float(line)
+            direction = Direction.OUTBOUND if speed > 0 else Direction.INBOUND
+
+            return SpeedReading(
+                speed=abs(speed),
+                direction=direction,
+                timestamp=time.time(),
+                unit=self._unit
+            )
         except (ValueError, json.JSONDecodeError):
             return None