Skip to content

Commit cdea737

Browse files
authored
WebAssembly support improvements (#56)
* Enable coverage reports and add ci step for the wasm build. The build should fail because the code is still not modified * Disable performance tests temporally * Fix import * Update wrong import * Disable some other performance tests * Enable back wasm fallback tests and revert a change made by mistake * Update clapack pacakge and add some guards to our code to prevent tentative errors * Disable some perf tests temporally for WASM * Fix CI by forcing the toolchain version we have to use * Implement some extra warnings when adding clapack library and using nsstring in lapack.swift code * Add support for the missing functions * Adapt the coverage we can use now * Disable one specific test we don't support * Remove duplicated section in wasm build * Replace CLAPACK library with pure swift
1 parent 93b6d43 commit cdea737

File tree

6 files changed

+1125
-95
lines changed

6 files changed

+1125
-95
lines changed

.github/workflows/wasm.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ name: wasm
22

33
on:
44
push:
5+
pull_request:
56

67
env:
78
# Required Swift toolchain version for WASM builds

Package.resolved

Lines changed: 0 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Package.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ let package = Package(
1212
],
1313
dependencies: [
1414
.package(url: "https://github.com/apple/swift-collections", from: "1.0.0"),
15-
.package(url: "https://github.com/goodnotes/CLAPACK", branch: "eigen-support"),
1615
],
1716
targets: [
1817
.target(
@@ -23,7 +22,6 @@ let package = Package(
2322
dependencies: [
2423
.product(name: "Collections", package: "swift-collections"),
2524
"pocketFFT",
26-
.product(name: "CLAPACK", package: "CLAPACK", condition: .when(platforms: [.wasi])),
2725
]),
2826
.testTarget(
2927
name: "MatftTests",

0 commit comments

Comments
 (0)