Skip to content
This repository was archived by the owner on Jan 8, 2025. It is now read-only.
This repository was archived by the owner on Jan 8, 2025. It is now read-only.

xmatch.cds does not handle duplicates correctly #23

@jobovy

Description

@jobovy

If an input catalog to xmatch.cds has duplicates, not every duplicate will necessarily get matched, because of this line, which in the cds_matchback function causes every object in the matched CDS catalog to be matched back to the original catalog, and this may lead to different objects being matched to, say, the first of a set of duplicates (rather than matching this object to each duplicate).

Possible fix: swap mc1 and mc2, but then have an index into the wrong array. An argsort can then swap this index into one into the correct array (I think).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions