Callback can be called twice

[eight04]

delete-empty/index.js

Lines 60 to 61 in 6ae3454

	.then(res => cb(null, res))
	.catch(cb);

If cb() throws an error, it will be called again within the error object.

[doowb]

Can you provide some example code with a case where this is causing a bug?

If so, a PR with a fix for the bug will be welcome.

[eight04]

const deleteEmpty = require("delete-empty");

const path = ".";

const onDone = (err, result) => {
  console.log("onDone", err, result);
  throw new Error("error in onDone");
};

try {
  deleteEmpty(path, onDone);
} catch (err) {
  console.log("err", err);
}

onDone is called twice. REPL

The correct code should be:

.then(
    res => cb(null, res),
    err => cb(err, null) // or just `cb`
)