[4.x] Update framework (#48)

* remove drone

* fix tests for phpunit12

* update composer dependencies

* update docs

* fix phpstan error, removed legacy code

* add baseline

* tabs

* use execptions as we are say in our tests

* fix testing // update phpunit12

* just one left

* Update src/Input.php

Author: rdeutz

.drone.jsonnet

@@ -234,19 +234,19 @@ Add `"joomla/input": "~3.0"` to the require block in your composer.json and then
 ```json
 {
 	"require": {
-		"joomla/input": "~3.0"
+		"joomla/input": "~4.0"
 	}
 }
 ```
 
 Alternatively, you can simply run the following from the command line:
 
 ```sh
-composer require joomla/input "~3.0"
+composer require joomla/input "~4.0"
 ```
 
 If you want to include the test sources, use
 
 ```sh
-composer require --prefer-source joomla/input "~3.0"
+composer require --prefer-source joomla/input "~4.0"
 ```

.drone.yml

@@ -5,7 +5,8 @@
 These versions are currently being supported with security updates:
 
 | Version | Supported          |
-| ------- | ------------------ |
+|---------| ------------------ |
+| 4.x.x   | :white_check_mark: |
 | 3.x.x   | :white_check_mark: |
 | 2.0.x   | :white_check_mark: |
 | 1.4.x   | :x:                |

README.md

@@ -76,23 +76,7 @@ public function test__constructDependencyInjection()
     }
 
     /**
-     * @testdox  Tests that data is correctly set with the legacy signature
-     *
-     * @covers   Joomla\Input\Cookie
-     * @uses     Joomla\Input\Input
-     */
-    public function testSetWithLegacySignature()
-    {
-        $mockFilter = $this->createMock(InputFilter::class);
-
-        $instance = new Cookie([], ['filter' => $mockFilter]);
-        $instance->set('foo', 'bar', 15);
-
-        $this->assertTrue(CookieDataStore::has('foo'));
-    }
-
-    /**
-     * @testdox  Tests that data is correctly set with the new signature
+     * @testdox  Tests that data is correctly set
      *
      * @covers   Joomla\Input\Cookie
      * @uses     Joomla\Input\Input
@@ -114,44 +98,9 @@ public function testSetWithNewSignature()
 
 use Joomla\Input\Tests\CookieDataStore;
 
-if (version_compare(PHP_VERSION, '7.3', '>=')) {
-    /**
-     * Stub.
-     *
-     * @param   string  $name     Name
-     * @param   string  $value    Value
-     * @param   array   $options  Expire
-     *
-     * @return  bool
-     *
-     * @since   1.1.4
-     */
-    function setcookie($name, $value, $options = [])
-    {
-        CookieDataStore::set($name, $value);
-
-        return true;
-    }
-} else {
-    /**
-     * Stub.
-     *
-     * @param   string  $name      Name
-     * @param   string  $value     Value
-     * @param   int     $expire    Expire
-     * @param   string  $path      Path
-     * @param   string  $domain    Domain
-     * @param   bool    $secure    Secure
-     * @param   bool    $httpOnly  HttpOnly
-     *
-     * @return  bool
-     *
-     * @since   1.1.4
-     */
-    function setcookie($name, $value, $expire = 0, $path = '', $domain = '', $secure = false, $httpOnly = false)
-    {
-        CookieDataStore::set($name, $value);
+function setcookie($name, $value, $options = [])
+{
+    CookieDataStore::set($name, $value);
 
-        return true;
-    }
+    return true;
 }