From 2c8c55bf638aa3aa4bdf007e9ae42f22eaf126c7 Mon Sep 17 00:00:00 2001
From: Jose Diaz-Gonzalez <email@josediazgonzalez.com>
Date: Fri, 24 Jan 2025 23:14:42 -0500
Subject: [PATCH] fix: correctly detect screenshot name

Previously, we would automatically set the name of the screenshot to the most recently played game. This is incorrect for cases where we are not currently _in_ a game, such as in the main ui.

To fix this, we now detect minarch.elf - as well as a slew of popular optional emulators - when checking if we should use the game name or a generic name. While this is a bit more annoying to upkeep - especially as folks port other custom emulators - this is a bit better as now we don't errantly mark a screenshot of the UI as a game.

Ideally we also detect if another custom pak is launched and use the pak's name as the screenshot name, but this is better than nothing.
---
 bin/screenshot | 35 +++++++++++++++++++++++++++++++++--
 1 file changed, 33 insertions(+), 2 deletions(-)

diff --git a/bin/screenshot b/bin/screenshot
index f1bd3e6..1b2934f 100755
--- a/bin/screenshot
+++ b/bin/screenshot
@@ -1,10 +1,41 @@
 #!/bin/sh
 
+get_screenshot_prefix() {
+    screenshot_prefix="$(cat /mnt/SDCARD/.userdata/shared/.minui/recent.txt | head -n1 | cut -d$'\t' -f2)"
+    if [ -z "$screenshot_prefix" ]; then
+        screenshot_prefix="Screenshot"
+    fi
+
+    is_running_minarch="false"
+    is_running_mupen64plus="false"
+    is_running_drastic="false"
+    is_running_ppsspp="false"
+    if pgrep "minarch.elf" >/dev/null 2>&1; then
+        is_running_minarch="true"
+    fi
+    if pgrep "mupen64plus" >/dev/null 2>&1; then
+        is_running_mupen64plus="true"
+    fi
+    if pgrep "drastic" >/dev/null 2>&1; then
+        is_running_drastic="true"
+    fi
+    if pgrep "PPSSPPSDL" >/dev/null 2>&1; then
+        is_running_ppsspp="true"
+    fi
+
+    if [ "$is_running_minarch" = "false" ] && [ "$is_running_mupen64plus" = "false" ] && [ "$is_running_drastic" = "false" ] && [ "$is_running_ppsspp" = "false" ]; then
+        screenshot_prefix="Screenshot"
+    fi
+
+    echo "$screenshot_prefix"
+}
+
 main() {
     mkdir -p /mnt/SDCARD/Screenshots/
-    game_name="$(cat /mnt/SDCARD/.userdata/shared/.minui/recent.txt | head -n1 | cut -d$'\t' -f2)"
     current_date="$(date +%Y-%m-%d-%H-%M-%S)"
-    /usr/trimui/bin/fbscreencap "/mnt/SDCARD/Screenshots/${game_name}.${current_date}.png"
+    screenshot_prefix="$(get_screenshot_prefix)"
+
+    /usr/trimui/bin/fbscreencap "/mnt/SDCARD/Screenshots/${screenshot_prefix}.${current_date}.png"
 }
 
 main "$@"