From 469a5acc67e95b98f3cb558d3ba11c869846e90e Mon Sep 17 00:00:00 2001 From: arjxn-py Date: Thu, 6 Feb 2025 16:03:50 +0530 Subject: [PATCH 1/3] Fix shared document interface --- packages/schema/src/interfaces.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/schema/src/interfaces.ts b/packages/schema/src/interfaces.ts index 8a7273c9c..84ea55d7f 100644 --- a/packages/schema/src/interfaces.ts +++ b/packages/schema/src/interfaces.ts @@ -109,6 +109,9 @@ export interface IJupyterCadDoc extends YDocument { setOutput(key: string, value: IPostResult): void; removeOutput(key: string): void; + getSource(): JSONObject; + setSource(value: JSONObject | string): void; + getMetadata(key: string): string | undefined; setMetadata(key: string, value: string): void; removeMetadata(key: string): void; From d3fd92add49b7572a8c93b3dbd1f70cb22b3d1e9 Mon Sep 17 00:00:00 2001 From: arjxn-py Date: Thu, 6 Feb 2025 16:36:41 +0530 Subject: [PATCH 2/3] getSource returns `JSONObject` --- packages/schema/src/doc.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/schema/src/doc.ts b/packages/schema/src/doc.ts index 64d052abc..911b62468 100644 --- a/packages/schema/src/doc.ts +++ b/packages/schema/src/doc.ts @@ -66,7 +66,7 @@ export class JupyterCadDoc return this._optionsChanged; } - getSource(): JSONValue | string { + getSource(): JSONObject { const objects = this._objects.toJSON(); const options = this._options.toJSON(); const metadata = this._metadata.toJSON(); From c33410f1e61051273785ad9393afde5ea749146d Mon Sep 17 00:00:00 2001 From: arjxn-py Date: Thu, 6 Feb 2025 17:18:09 +0530 Subject: [PATCH 3/3] change type for setSource too --- packages/schema/src/doc.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/schema/src/doc.ts b/packages/schema/src/doc.ts index 911b62468..368f515ef 100644 --- a/packages/schema/src/doc.ts +++ b/packages/schema/src/doc.ts @@ -1,5 +1,5 @@ import { MapChange, YDocument } from '@jupyter/ydoc'; -import { JSONExt, JSONObject, JSONValue } from '@lumino/coreutils'; +import { JSONExt, JSONObject } from '@lumino/coreutils'; import { ISignal, Signal } from '@lumino/signaling'; import * as Y from 'yjs'; @@ -75,7 +75,7 @@ export class JupyterCadDoc return { objects, options, metadata, outputs }; } - setSource(value: JSONValue): void { + setSource(value: JSONObject | string): void { if (!value) { return; }