Add conditional guards for duplicate key detection specs based on JSON gem version support

Author: ydah

spec/jwt/claims/duplicate_key_spec.rb

@@ -37,13 +37,20 @@ def build_jwt_with_duplicate_header(duplicate_header_json, payload_json = '{"sub
       end
 
       context 'with raise_on_duplicate_keys!' do
-        it 'raises DuplicateKeyError' do
+        it 'raises DuplicateKeyError', if: JWT::JSON.supports_duplicate_key_detection? do
           token = JWT::EncodedToken.new(duplicate_payload_jwt)
           token.raise_on_duplicate_keys!
           expect do
             token.unverified_payload
           end.to raise_error(JWT::DuplicateKeyError, /duplicate key/)
         end
+
+        it 'raises UnsupportedError', unless: JWT::JSON.supports_duplicate_key_detection? do
+          token = JWT::EncodedToken.new(duplicate_payload_jwt)
+          expect do
+            token.raise_on_duplicate_keys!
+          end.to raise_error(JWT::UnsupportedError, /JSON gem >= 2\.13\.0/)
+        end
       end
     end
 
@@ -58,17 +65,24 @@ def build_jwt_with_duplicate_header(duplicate_header_json, payload_json = '{"sub
       end
 
       context 'with raise_on_duplicate_keys!' do
-        it 'raises DuplicateKeyError for header' do
+        it 'raises DuplicateKeyError for header', if: JWT::JSON.supports_duplicate_key_detection? do
           token = JWT::EncodedToken.new(duplicate_header_jwt)
           token.raise_on_duplicate_keys!
           expect do
             token.header
           end.to raise_error(JWT::DuplicateKeyError, /duplicate key/)
         end
+
+        it 'raises UnsupportedError', unless: JWT::JSON.supports_duplicate_key_detection? do
+          token = JWT::EncodedToken.new(duplicate_header_jwt)
+          expect do
+            token.raise_on_duplicate_keys!
+          end.to raise_error(JWT::UnsupportedError, /JSON gem >= 2\.13\.0/)
+        end
       end
     end
 
-    describe 'chaining' do
+    describe 'chaining', if: JWT::JSON.supports_duplicate_key_detection? do
       let(:valid_jwt) { build_jwt_with_duplicate_payload('{"sub":"user"}') }
 
       it 'returns self for method chaining' do
@@ -77,7 +91,7 @@ def build_jwt_with_duplicate_header(duplicate_header_json, payload_json = '{"sub
       end
     end
 
-    describe 'valid tokens' do
+    describe 'valid tokens', if: JWT::JSON.supports_duplicate_key_detection? do
       let(:valid_jwt) { build_jwt_with_duplicate_payload('{"sub":"user","name":"John"}') }
 
       it 'parses valid JSON without duplicates' do
@@ -92,13 +106,20 @@ def build_jwt_with_duplicate_header(duplicate_header_json, payload_json = '{"sub
     let(:multiple_duplicates_jwt) { build_jwt_with_duplicate_payload('{"a":1,"b":2,"a":3,"b":4}') }
 
     context 'with raise_on_duplicate_keys!' do
-      it 'raises DuplicateKeyError for the first duplicate found' do
+      it 'raises DuplicateKeyError for the first duplicate found', if: JWT::JSON.supports_duplicate_key_detection? do
         token = JWT::EncodedToken.new(multiple_duplicates_jwt)
         token.raise_on_duplicate_keys!
         expect do
           token.unverified_payload
         end.to raise_error(JWT::DuplicateKeyError, /duplicate key/)
       end
+
+      it 'raises UnsupportedError', unless: JWT::JSON.supports_duplicate_key_detection? do
+        token = JWT::EncodedToken.new(multiple_duplicates_jwt)
+        expect do
+          token.raise_on_duplicate_keys!
+        end.to raise_error(JWT::UnsupportedError, /JSON gem >= 2\.13\.0/)
+      end
     end
   end
 end

spec/jwt/json_spec.rb

@@ -21,29 +21,38 @@
     end
 
     context 'with allow_duplicate_keys: false' do
-      it 'raises DuplicateKeyError for duplicate keys' do
-        expect do
-          described_class.parse('{"a":1,"a":2}', allow_duplicate_keys: false)
-        end.to raise_error(JWT::DuplicateKeyError, /duplicate key/)
-      end
+      context 'when JSON gem supports duplicate key detection', if: JWT::JSON.supports_duplicate_key_detection? do
+        it 'raises DuplicateKeyError for duplicate keys' do
+          expect do
+            described_class.parse('{"a":1,"a":2}', allow_duplicate_keys: false)
+          end.to raise_error(JWT::DuplicateKeyError, /duplicate key/)
+        end
 
-      it 'parses valid JSON without duplicates' do
-        result = described_class.parse('{"a":1,"b":2}', allow_duplicate_keys: false)
-        expect(result).to eq({ 'a' => 1, 'b' => 2 })
-      end
+        it 'parses valid JSON without duplicates' do
+          result = described_class.parse('{"a":1,"b":2}', allow_duplicate_keys: false)
+          expect(result).to eq({ 'a' => 1, 'b' => 2 })
+        end
+
+        it 'detects duplicates in nested objects' do
+          json = '{"outer":{"inner":1,"inner":2}}'
+          expect do
+            described_class.parse(json, allow_duplicate_keys: false)
+          end.to raise_error(JWT::DuplicateKeyError, /duplicate key/)
+        end
 
-      it 'detects duplicates in nested objects' do
-        json = '{"outer":{"inner":1,"inner":2}}'
-        expect do
-          described_class.parse(json, allow_duplicate_keys: false)
-        end.to raise_error(JWT::DuplicateKeyError, /duplicate key/)
+        it 'allows same key in different objects' do
+          json = '{"obj1":{"a":1},"obj2":{"a":2}}'
+          result = described_class.parse(json, allow_duplicate_keys: false)
+          expect(result['obj1']['a']).to eq(1)
+          expect(result['obj2']['a']).to eq(2)
+        end
       end
 
-      it 'allows same key in different objects' do
-        json = '{"obj1":{"a":1},"obj2":{"a":2}}'
-        result = described_class.parse(json, allow_duplicate_keys: false)
-        expect(result['obj1']['a']).to eq(1)
-        expect(result['obj2']['a']).to eq(2)
+      context 'when JSON gem does not support duplicate key detection', unless: JWT::JSON.supports_duplicate_key_detection? do
+        it 'silently allows duplicate keys (uses last value)' do
+          result = described_class.parse('{"a":1,"a":2}', allow_duplicate_keys: false)
+          expect(result['a']).to eq(2)
+        end
       end
     end
   end