fix: logical expression transformation

Author: kermanx

crates/jsshaker/src/nodes/expr/assignment_expression.rs

@@ -94,19 +94,22 @@ impl<'a> Transformer<'a> {
     let transformed_right = self.transform_expression(right, need_val || !left_is_empty);
 
     match (transformed_left, transformed_right) {
-      (Some(left), right) => Some(self.ast.expression_assignment(
-        *span,
-        if operator.is_logical() {
-          let (_, maybe_left, _) =
-            self.get_conditional_result(AstKind2::LogicalAssignmentExpressionLeft(node), false);
+      (Some(left), right) => {
+        debug_assert!(!left_is_empty);
+        Some(self.ast.expression_assignment(
+          *span,
+          if operator.is_logical() {
+            let (_, maybe_left, _) =
+              self.get_conditional_result(AstKind2::LogicalAssignmentExpressionLeft(node), false);
 
-          if maybe_left { *operator } else { AssignmentOperator::Assign }
-        } else {
-          *operator
-        },
-        left,
-        right.unwrap(),
-      )),
+            if maybe_left { *operator } else { AssignmentOperator::Assign }
+          } else {
+            *operator
+          },
+          left,
+          right.unwrap(),
+        ))
+      }
       (None, Some(right)) => {
         if need_val && *operator != AssignmentOperator::Assign {
           if operator.is_logical() {

crates/jsshaker/src/nodes/expr/logical_expression.rs

@@ -85,6 +85,8 @@ impl<'a> Transformer<'a> {
       } else {
         Some(left)
       }
+    } else if need_val && left.is_none() && right.is_none() {
+      Some(self.build_unused_expression(*span))
     } else {
       build_effect!(self.ast, *span, left, right)
     }

crates/jsshaker/src/nodes/expr/mod.rs

@@ -205,6 +205,10 @@ impl<'a> Transformer<'a> {
         Some(literal)
       }
     } else {
+      if need_val {
+        debug_assert!(inner.is_some(), "Expr: {:#?}", node);
+      }
+
       inner
     }
   }