Project Review

[rahulkore]

#Functionality Wise

Pros

• Wireframing looks good.
• Good job on using breadcrumbs in website
• Good job on using API's to fetch the data for website ionstead of just static content

cons

• No client side data validation present on login/signup
• After login/signup white page appears with nothing , have to reload the page to keep it working.
• When I change the city filter , nothing changes , it is probably just statically coded in the website, if feature is not working please do not keep in the website.
• cart does not work.
• On a meta level , Always remeber if certain feature you haven't implemented properly then just remove it. A Website with few working features is more
  interesting and functional than a website with n different things out of which only few works.

#Coding

• UI

• Pros

  • UI looks good , looks attractive , good job on that part .
  • The wireframe looks great overall.
  • The navigation is smooth on the site.
  • latency is within limits on event fires.
  • Functionality those are included works fine although some enhancements could've done .
  • Redux arch is used properly , kudos on that .
  • Hooks understanding is also on point .
  • Standard Coding practices are used .

• Cons

  • Some links are broken .
  • No comments in code / Always include comments

• Backend

  • For OTP feature , try looking into "Twilio" framework that way actually the OTP's will be sent on device. https://www.twilio.com/blog/phone-verification-react-native
  • No data validation / sanitation