Skip to content

Commit e0b3ef4

Browse files
committed
Use listType atomic for PodTemplateOverrideTargetJob
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
1 parent 6ac623c commit e0b3ef4

File tree

5 files changed

+5
-16
lines changed

5 files changed

+5
-16
lines changed

api/openapi-spec/swagger.json

Lines changed: 1 addition & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

charts/kubeflow-trainer/crds/trainer.kubeflow.org_trainjobs.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4610,9 +4610,7 @@ spec:
46104610
- name
46114611
type: object
46124612
type: array
4613-
x-kubernetes-list-map-keys:
4614-
- name
4615-
x-kubernetes-list-type: map
4613+
x-kubernetes-list-type: atomic
46164614
required:
46174615
- targetJobs
46184616
type: object

manifests/base/crds/trainer.kubeflow.org_trainjobs.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4610,9 +4610,7 @@ spec:
46104610
- name
46114611
type: object
46124612
type: array
4613-
x-kubernetes-list-map-keys:
4614-
- name
4615-
x-kubernetes-list-type: map
4613+
x-kubernetes-list-type: atomic
46164614
required:
46174615
- targetJobs
46184616
type: object

pkg/apis/trainer/v1alpha1/trainjob_types.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,8 +266,7 @@ type Trainer struct {
266266
// PodTemplateOverride represents a custom PodTemplateSpec override that will be applied to the TrainJob's training runtime.
267267
type PodTemplateOverride struct {
268268
// targetJobs is the list of replicated jobs in the training runtime template to apply the overrides.
269-
// +listType=map
270-
// +listMapKey=name
269+
// +listType=atomic
271270
// +required
272271
TargetJobs []PodTemplateOverrideTargetJob `json:"targetJobs,omitempty"`
273272

pkg/apis/trainer/v1alpha1/zz_generated.openapi.go

Lines changed: 1 addition & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)