Skip to content
This repository was archived by the owner on Jan 24, 2019. It is now read-only.

Commit 7cc365a

Browse files
committed
Merge branch 'release/1.0.1'
2 parents 6372f74 + 0b60003 commit 7cc365a

File tree

9 files changed

+71
-52
lines changed

9 files changed

+71
-52
lines changed

OrangeFramework.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
Pod::Spec.new do |s|
77
s.name = "OrangeFramework"
8-
s.version = "1.0.0"
8+
s.version = "1.0.1"
99
s.summary = "Powerful framework aimed at fast and high quality developing mobile apps on Objective-C and Swift."
1010
s.description = <<-DESC
1111
OrangeFramework is a collection of components for fast and high quality developing mobile apps on Objective-C and Swift.

OrangeFrameworkObjC.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
Pod::Spec.new do |s|
77
s.name = "OrangeFrameworkObjC"
8-
s.version = "1.0.0"
8+
s.version = "1.0.1"
99
s.summary = "Powerful framework aimed at fast and high quality developing mobile apps on Objective-C."
1010
s.description = <<-DESC
1111
OrangeFramework is a collection of components for fast and high quality developing mobile apps on Objective-C.

Source/Extensions/Foundation/NSError+OFExtension.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ NS_ASSUME_NONNULL_BEGIN
44

55
@interface NSError (OFExtension)
66

7-
+ (instancetype)of_errorWithDomainObject:(id)domainObject description:(NSString *)description NS_SWIFT_NAME(init(of_domainObject:description:));
8-
+ (instancetype)of_errorWithDomainObject:(id)domainObject code:(NSInteger)code description:(NSString *)description NS_SWIFT_NAME(init(of_domainObject:code:description:));
7+
+ (instancetype)of_errorWithDomainObject:(id)domainObject description:(NSString *)description NS_SWIFT_UNAVAILABLE("Use swift init instead");
8+
+ (instancetype)of_errorWithDomainObject:(id)domainObject code:(NSInteger)code description:(NSString *)description NS_SWIFT_UNAVAILABLE("Use swift init instead");
99

1010
@end
1111

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
import Foundation
2+
3+
public extension NSError {
4+
5+
public convenience init<T>(of_domainObject: T, code: Int = 0, description: String) {
6+
self.init(domain: String(reflecting: T.self), code: code, userInfo: [NSLocalizedDescriptionKey: description])
7+
}
8+
9+
}
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
#import <Foundation/Foundation.h>
2+
3+
NS_INLINE void of_warning() __deprecated_msg("___ REMINDER ___");
4+
void of_warning() {}

Source/Extensions/OFExtensions.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
#import "NSDate+OFExtension.h"
88
#import "NSError+OFExtension.h"
99
#import "NSString+OFExtension.h"
10+
#import "Warning+OFExtension.h"
1011

1112
// UIKit
1213
#import "Geometry+OFExtension.h"

Source/Log/Log.swift

Lines changed: 19 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,44 @@
11
import Foundation
22

3-
public typealias LogFlag = OFLogFlag
4-
public typealias LogHandler = ((lazyFormattedMessage: () -> String, rawMessage: String?, flag: LogFlag, function: String, file: String, line: UInt32) -> Bool)
3+
public typealias LogLevel = OFLogLevel
4+
public typealias LogHandler = ((lazyFormattedMessage: () -> String, rawMessage: String?, level: LogLevel, function: String, file: String, line: UInt32) -> Bool)
55

66
public class Log {
77

8-
/// set which message should be print in console, default handler return true when DEBUG preprocessor symbol defined and false otherwise
8+
/// log handler, decide which message should print, by default print all in DEBUG and nothing otherwise
99
public class func setHandler(handler: LogHandler?) {
1010
OFLogSetHandler(handler)
1111
}
1212

1313
public class func error(value: Any?, _ function: String = __FUNCTION__, _ file: String = __FILE__, _ line: UInt32 = __LINE__) {
14-
let message: String? = (value == nil) ? nil : String(reflecting: value!)
15-
OFLog(message, .Error, function, file, line)
14+
OFLog("\(value)", LogLevel.Error, function, file, line)
1615
}
1716

1817
public class func warning(value: Any?, _ function: String = __FUNCTION__, _ file: String = __FILE__, _ line: UInt32 = __LINE__) {
19-
let message: String? = (value == nil) ? nil : String(reflecting: value!)
20-
OFLog(message, .Warning, function, file, line)
18+
OFLog("\(value)", LogLevel.Warning, function, file, line)
2119
}
2220

2321
public class func info(value: Any?, _ function: String = __FUNCTION__, _ file: String = __FILE__, _ line: UInt32 = __LINE__) {
24-
let message: String? = (value == nil) ? nil : String(reflecting: value!)
25-
OFLog(message, .Info, function, file, line)
22+
OFLog("\(value)", LogLevel.Info, function, file, line)
2623
}
2724

2825
public class func debug(value: Any?, _ function: String = __FUNCTION__, _ file: String = __FILE__, _ line: UInt32 = __LINE__) {
29-
let message: String? = (value == nil) ? nil : String(reflecting: value!)
30-
OFLog(message, .Debug, function, file, line)
26+
OFLog("\(value)", LogLevel.Debug, function, file, line)
3127
}
3228

3329
public class func verbose(value: Any?, _ function: String = __FUNCTION__, _ file: String = __FILE__, _ line: UInt32 = __LINE__) {
34-
let message: String? = (value == nil) ? nil : String(reflecting: value!)
35-
OFLog(message, .Verbose, function, file, line)
30+
OFLog("\(value)", LogLevel.Verbose, function, file, line)
3631
}
3732

33+
}
34+
35+
36+
extension LogLevel: Comparable {}
37+
38+
public func ==(lhs: LogLevel, rhs: LogLevel) -> Bool {
39+
return lhs.rawValue == rhs.rawValue
40+
}
41+
42+
public func <(lhs: LogLevel, rhs: LogLevel) -> Bool {
43+
return lhs.rawValue < rhs.rawValue
3844
}

Source/Log/OFLog.h

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -2,31 +2,31 @@
22

33
NS_ASSUME_NONNULL_BEGIN
44

5-
typedef NS_ENUM(NSInteger, OFLogFlag)
5+
typedef NS_ENUM(NSInteger, OFLogLevel)
66
{
7-
OFLogFlagError,
8-
OFLogFlagWarning,
9-
OFLogFlagInfo,
10-
OFLogFlagDebug,
11-
OFLogFlagVerbose
7+
OFLogLevelError,
8+
OFLogLevelWarning,
9+
OFLogLevelInfo,
10+
OFLogLevelDebug,
11+
OFLogLevelVerbose
1212
};
1313

1414
typedef NSString * _Nonnull (^OFLogLazyMessage)(void);
15-
typedef BOOL (^OFLogHandler)(OFLogLazyMessage lazyFormattedMessage, NSString * _Nullable rawMessage, OFLogFlag flag, NSString *function, NSString *file, unsigned int line);
15+
typedef BOOL (^OFLogHandler)(OFLogLazyMessage lazyFormattedMessage, NSString * _Nullable rawMessage, OFLogLevel level, NSString *function, NSString *file, unsigned int line);
1616

17-
FOUNDATION_EXPORT void OFLog(NSString * _Nullable message, OFLogFlag flag, NSString *function, NSString *file, unsigned int line);
18-
FOUNDATION_EXPORT void OFLogSetHandler(OFLogHandler _Nullable handler); // set which message should be print in console, default handler return YES in DEBUG and NO otherwise
17+
FOUNDATION_EXPORT void OFLog(NSString * _Nullable message, OFLogLevel level, NSString *function, NSString *file, unsigned int line);
18+
FOUNDATION_EXPORT void OFLogSetHandler(OFLogHandler _Nullable handler); // log handler, decide which message should print, by default print all in DEBUG and nothing otherwise
1919

20-
#define OFLogError(format, ...) OFLog([NSString stringWithFormat:format,##__VA_ARGS__], OFLogFlagError, __func__, __FILE__, __LINE__)
21-
#define OFLogWarning(format,...) OFLog([NSString stringWithFormat:format,##__VA_ARGS__], OFLogFlagWarning, __func__, __FILE__, __LINE__)
22-
#define OFLogInfo(format, ...) OFLog([NSString stringWithFormat:format,##__VA_ARGS__], OFLogFlagInfo, __func__, __FILE__, __LINE__)
23-
#define OFLogDebug(format, ...) OFLog([NSString stringWithFormat:format,##__VA_ARGS__], OFLogFlagDebug, __func__, __FILE__, __LINE__)
24-
#define OFLogVerbose(format, ...) OFLog([NSString stringWithFormat:format,##__VA_ARGS__], OFLogFlagVerbose, __func__, __FILE__, __LINE__)
20+
#define OFLogError(format, ...) OFLog([NSString stringWithFormat:format,##__VA_ARGS__], OFLogLevelError, __func__, __FILE__, __LINE__)
21+
#define OFLogWarning(format,...) OFLog([NSString stringWithFormat:format,##__VA_ARGS__], OFLogLevelWarning, __func__, __FILE__, __LINE__)
22+
#define OFLogInfo(format, ...) OFLog([NSString stringWithFormat:format,##__VA_ARGS__], OFLogLevelInfo, __func__, __FILE__, __LINE__)
23+
#define OFLogDebug(format, ...) OFLog([NSString stringWithFormat:format,##__VA_ARGS__], OFLogLevelDebug, __func__, __FILE__, __LINE__)
24+
#define OFLogVerbose(format, ...) OFLog([NSString stringWithFormat:format,##__VA_ARGS__], OFLogLevelVerbose, __func__, __FILE__, __LINE__)
2525

26-
#define OFLogErrorObject(object) OFLog([object debugDescription], OFLogFlagError, __func__, __FILE__, __LINE__)
27-
#define OFLogWarningObject(object) OFLog([object debugDescription], OFLogFlagWarning, __func__, __FILE__, __LINE__)
28-
#define OFLogInfoObject(object) OFLog([object debugDescription], OFLogFlagInfo, __func__, __FILE__, __LINE__)
29-
#define OFLogDebugObject(object) OFLog([object debugDescription], OFLogFlagDebug, __func__, __FILE__, __LINE__)
30-
#define OFLogVerboseObject(object) OFLog([object debugDescription], OFLogFlagVerbose, __func__, __FILE__, __LINE__)
26+
#define OFLogErrorObject(object) OFLog([object description], OFLogLevelError, __func__, __FILE__, __LINE__)
27+
#define OFLogWarningObject(object) OFLog([object description], OFLogLevelWarning, __func__, __FILE__, __LINE__)
28+
#define OFLogInfoObject(object) OFLog([object description], OFLogLevelInfo, __func__, __FILE__, __LINE__)
29+
#define OFLogDebugObject(object) OFLog([object description], OFLogLevelDebug, __func__, __FILE__, __LINE__)
30+
#define OFLogVerboseObject(object) OFLog([object description], OFLogLevelVerbose, __func__, __FILE__, __LINE__)
3131

3232
NS_ASSUME_NONNULL_END

Source/Log/OFLog.m

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,37 +11,36 @@ void OFLogSetHandler(OFLogHandler handler) {
1111
_handler = [handler copy];
1212
}
1313

14-
void OFLog(NSString * _Nullable message, OFLogFlag flag, NSString *function, NSString *file, unsigned int line) {
14+
void OFLog(NSString * _Nullable message, OFLogLevel level, NSString *function, NSString *file, unsigned int line) {
1515
__block NSString *formattedMessage = nil;
1616
OFLogLazyMessage lazyFormattedMessage = ^NSString * _Nonnull {
1717
if (!formattedMessage) {
1818
NSDateFormatter *dateFormatter = [NSDateFormatter new];
1919
dateFormatter.dateFormat = [NSDateFormatter dateFormatFromTemplate:@"ddMMyyyy HHmmssSSS" options:0 locale:nil];
2020
NSString *timeString = [dateFormatter stringFromDate:[NSDate date]];
21-
NSString *flagString;
22-
switch (flag) {
23-
case OFLogFlagError:
24-
flagString = @"ERROR";
21+
NSString *levelString;
22+
switch (level) {
23+
case OFLogLevelError:
24+
levelString = @"ERROR";
2525
break;
26-
case OFLogFlagWarning:
27-
flagString = @"WARNING";
26+
case OFLogLevelWarning:
27+
levelString = @"WARNING";
2828
break;
29-
case OFLogFlagDebug:
30-
flagString = @"DEBUG";
29+
case OFLogLevelDebug:
30+
levelString = @"DEBUG";
3131
break;
32-
case OFLogFlagInfo:
33-
flagString = @"INFO";
34-
break;
35-
case OFLogFlagVerbose:
36-
flagString = @"VERBOSE";
32+
case OFLogLevelInfo:
33+
levelString = @"INFO";
3734
break;
35+
case OFLogLevelVerbose:
36+
levelString = @"VERBOSE";
3837
}
3938
NSString *filename = [file lastPathComponent];
40-
formattedMessage = [NSString stringWithFormat:@"%@ [%@] %@:%d (%@): %@", timeString, flagString, filename, line, function, message];
39+
formattedMessage = [NSString stringWithFormat:@"%@ [%@] %@:%d (%@): %@", timeString, levelString, filename, line, function, message];
4140
}
4241
return formattedMessage;
4342
};
44-
if ( (!_handler && _defaultHandlerResult) || (_handler && _handler(lazyFormattedMessage, message, flag, function, file, line)) ) {
43+
if ( (!_handler && _defaultHandlerResult) || (_handler && _handler(lazyFormattedMessage, message, level, function, file, line)) ) {
4544
printf("%s\n", [lazyFormattedMessage() UTF8String]);
4645
}
4746
}

0 commit comments

Comments
 (0)