-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Description
So I've been using this repository as inspiration for translation to another language (Kotlin)...
And if you do similar - be very, very careful. There's a few hacky pieces in here that cause readability issues and typically wouldn't get past a code review, like:
- issues with separation of concerns (the LexoRank class contains a lot of Decimal functionality), somewhat breaking Demeter's
- unclear use of statics
- reassigning method/function parameters
- reassigning values in for loop declarations
Sure, some of it is the C# <> Kotlin translation, but a lot of these issues are not.
The code itself here seems to mostly work, however the range of tests here don't really stress-test the algorithm, and I suggest you do so to validate your implementation and usage...
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels