VIP/PID and PCSC-lite issues with recognising the picokey #27
Replies: 9 comments 17 replies
-
|
I copy here what I last wrote in #18 to continue the discussion : I think that for the long term, the best would be to have a valid VID/PID for identifying pico keys that we can communicate to pcsc-lite team to be included in their upstream package. Raspberry and Espressif can provide free PIDs for products based on their micro-controllers (but maybe this is more targeted at commercial hardware products than open source software communities): There are at least 2 organizations that can provide free PIDs for open source projects : |
Beta Was this translation helpful? Give feedback.
-
|
Looks like PH has obtained a PID for pico-fido from raspberry : Lab-8916100448256/pico-fido@f2eef5b |
Beta Was this translation helpful? Give feedback.
-
|
We may have to hard fork the pico-fido firmware to request our own PID though |
Beta Was this translation helpful? Give feedback.
-
|
@Lab-8916100448256 We have a hard fork of pico-fido2 right now, so we can use that to get our own PID? |
Beta Was this translation helpful? Give feedback.
-
Right! Maybe that can do it, yes. |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, maybe we can try applying for a pid on this: https://wiki.openmoko.org/wiki/USB_Product_IDs Problem with pid-codes is this: pidcodes/pidcodes.github.com#480 |
Beta Was this translation helpful? Give feedback.
-
Well, it is the same with openmoko. But it should not be a concern. It is just the USB-IF that does not like these org to sub-licence PIDs under their VID. |
Beta Was this translation helpful? Give feedback.
-
|
@lockedmutex |
Beta Was this translation helpful? Give feedback.
-
|
Give an update when you get update about the request from openmoko. |
Beta Was this translation helpful? Give feedback.
-
|
@lockedmutex , answer from openmoko :
|
Beta Was this translation helpful? Give feedback.
-
|
So we are need to make changes in all the forks that we made of picokey repos? or only the pico-fido2 or pico-keys-sdk? |
Beta Was this translation helpful? Give feedback.
-
|
I think in all the forks for which we want to build and publish binaries with the PID they will provide. |
Beta Was this translation helpful? Give feedback.
-
|
I see, so I guess, we will need to start work on this? we will make all the require changes, and then keep layering updates from upstream(PH repo) to our repos. That way we will also get upstream updates and we also satisfy what Openmoko needs. You can start the refactors with one of the above forks, you can choose, I will start with any other one that u did not choose later, and slowly we will make the required changes to all the forks and request again. |
Beta Was this translation helpful? Give feedback.
-
|
Yes, that's what we have to do. |
Beta Was this translation helpful? Give feedback.
-
|
Sure works with me, I will get the UI done. |
Beta Was this translation helpful? Give feedback.
-
|
There is just one thing that is not clear to me. What should we put as the copyright owner for the files that are not inherited from picokeys and newly created by us. Do we put the name of the person that first created the file? Or do we put the name of a non profit librekeys" organization that would be an informal organization or something that we would have to formally create later on? |
Beta Was this translation helpful? Give feedback.
-
|
For repos created by us, like lets say you created one and you are the primary person maintaining it then you will be the copyright owner of the files, not the organisation. However if there is a repo, that was created by two or more people and all of them have been contributing from initial commits, in that case the copyright holder will be the organisation. There can be special cases, like lets say a repo was created and started by you, but later since you did not get time, you hand it over to someone else to maintain the repo, in that case the copyright holders will be you and the new maintainer, and if the new maintainer is also in the organisation then in that case copyright holder will be the organisation. Like right now the sole copyright holder of picoforge is me, but if I decide to step down in future then I will still remain the copyright holder but also add picoforge org. after me as copyright holders. Tho one rule that I will soft enforce, if you want to add and contribute to any repo inside picoforge and have copyrights to it then you have to license it under GPL licenses, AGPL preferred. This topic is kinda more complex, I will later discuss it on discord. I might also be wrong in some of the stuff I said above. But right now any new repo you create and you work on (for eg. a firmware or an application) then you are the copyright holder but for repos that use to store 3D prints model files in that case put the copyright holders as the picoforge organisation and license it MIT or Apache. |
Beta Was this translation helpful? Give feedback.
-
|
I've made the required changes in pico-fido2 and pico-fido-sdk, in branches. |
Beta Was this translation helpful? Give feedback.
-
|
Sure go ahead, make hard forks of the repos. |
Beta Was this translation helpful? Give feedback.
-
|
I do not have the rights to delete the repos to replace them with a hard fork |
Beta Was this translation helpful? Give feedback.
-
|
I renamed pico-keys-sdk and pico-fido to indicate the are soft forks. now you can create new repos that are hard forks. |
Beta Was this translation helpful? Give feedback.
-
|
can you do that also for pico-openpgp and pico-hsm?
|
Beta Was this translation helpful? Give feedback.
-
|
done |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
@Lab-8916100448256 @jetcookies Discussion on fixes and long term solutions for issue #18
Beta Was this translation helpful? Give feedback.
All reactions