Skip to content

Add global TLS verification skip setting #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaycollett wants to merge 1 commit into
base: 2.x
Choose a base branch
from
+20 −0
Open

Add global TLS verification skip setting #1535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/SupportedApps.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ public function execute(
'connect_timeout' => 15,
] : $overridevars;

// Check global setting to skip TLS verification (useful for self-signed certificates)
if (Setting::fetch('skip_tls_verification')) {
$vars['verify'] = false;
}

$client = new Client($vars);

$method = ($overridemethod === null || $overridemethod === false) ? $this->method : $overridemethod;
Expand Down
14 changes: 14 additions & 0 deletions database/seeders/SettingsSeeder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,5 +349,19 @@ public function run(): void
$setting->label = 'app.settings.treat_tags_as';
$setting->save();
}

if (! $setting = Setting::find(15)) {
$setting = new Setting;
$setting->id = 15;
$setting->group_id = 4;
$setting->key = 'skip_tls_verification';
$setting->type = 'boolean';
$setting->label = 'app.settings.skip_tls_verification';
$setting->value = '0';
$setting->save();
} else {
$setting->label = 'app.settings.skip_tls_verification';
$setting->save();
}
}
}
1 change: 1 addition & 0 deletions lang/en/app.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
'settings.folders' => 'Folders',
'settings.tags' => 'Tags',
'settings.categories' => 'Categories',
'settings.skip_tls_verification' => 'Skip TLS Verification (for self-signed certificates)',
'options.none' => '- not set -',
'options.google' => 'Google',
'options.ddg' => 'DuckDuckGo',
Expand Down