Enhancement: add a migration config to a driver config

[euri10]

Summary

i'd like a way to add a migration config after I created a driver config.
that would let me do something like the below:

from typing import Any, Self
from sqlspec import AsyncDatabaseConfig, SQLSpec, SyncDatabaseConfig
from sqlspec.adapters.sqlite import SqliteConfig

class KS:
    def __init__(self, spec: SQLSpec, config: SyncDatabaseConfig[Any, Any, Any] | AsyncDatabaseConfig[Any, Any, Any],
                 ) -> None:
        self.spec = spec
        self.config = config


    @classmethod
    def create(cls, spec: SQLSpec, config: SyncDatabaseConfig[Any, Any, Any, ])-> Self:
        self = cls(spec=spec, config=config, )
        # here i'd like something like config.add_migration_coonfig(toto)
        current = config.get_current_migration()
        if not current:
            try:
                config.migrate_up(echo=True)
            except Exception as e:
                print(f"Migration failed: {e}")
                raise e 
        return self



spec = SQLSpec()
config = SqliteConfig(connection_config={"database": "tt.db"},)
ks = KS.create(spec, config)

weirdly enough the above raises with a sqlspec.exceptions.SQLFileNotFoundError: SQL file 'migrations/0001_init.sql' not found but I'm positive the file exists.

also if I add a migration_config to the sqlite config above, then it finds there is one migration, and it fails because the file is not found, how can it not find the file if it detected it in the first place ?

Basic Example

No response

Drawbacks and Impact

No response

Unresolved questions

No response

[euri10]

it seems like it's somewhere in _resolve_path where the base_path is added to the migration filepath:

so I end up with:
▾ base_path PosixPath = PosixPath('/home/lotso/code/johnnycanencrypt/johnnycanencrypt/migrations')
▸ p PosixPath = PosixPath('migrations/0001_init.sql')

[euri10]

workaround for now, using a private mehtod on the driver config seems to work fine though:

from pathlib import Path
from typing import Any, Self
from sqlspec import AsyncDatabaseConfig, SQLSpec, SyncDatabaseConfig
from sqlspec.adapters.sqlite import SqliteConfig



class KS:
    def __init__(self, spec: SQLSpec, config: SyncDatabaseConfig[Any, Any, Any] | AsyncDatabaseConfig[Any, Any, Any],
                 ) -> None:
        self.spec = spec
        self.config = config


    @classmethod
    def create(cls, spec: SQLSpec, config: SyncDatabaseConfig[Any, Any, Any, ])-> Self:
        self = cls(spec=spec, config=config)
        # workaround
        migration_config={"script_location": Path(__file__).parent / "m"}
        config.migration_config = migration_config
        config._initialize_migration_components()
        current = config.get_current_migration()
        if not current:
            try:
                config.migrate_up(echo=True)
            except Exception as e:
                print(f"Migration failed: {e}")
                raise e 
        return self



spec = SQLSpec()
config = SqliteConfig(connection_config={"database": "tt.db"},
                      )
ks = KS.create(spec, config)