feat!: add automated cleanup of srgb-converted file to avoid accumulating garbage

- Vips processor required moving the srgb conversion to a different location, because it only reads source file lazily,
on attempt to write.
- jpgicc leaves empty file on failure (and it happens to fail on grayscale, thus the shared examples are in two places)

Author: knarewski-livelink

.gitignore

@@ -23,4 +23,3 @@ sample/
 Makefile
 *.rdb
 tags
-*.icc.jpg

CHANGELOG.md

@@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 ## [0.101.0] 14.01.2026
+### Added
+- [BREAKING] introduced automated cleanup of srgb files after processing
+
 ### Removed
 - [BREAKING] support for custom srgb file path
 

lib/morandi.rb

@@ -57,7 +57,10 @@ def process(source, options, target_path, local_options = {})
       cache_max = 0
       concurrency = 2 # Hardcoding to 2 for now to maintain some balance between resource usage and performance
       VipsImageProcessor.with_global_options(cache_max: cache_max, concurrency: concurrency) do
-        VipsImageProcessor.new(source, options).write_to_jpeg(target_path)
+        srgb_converted_file_path = Morandi::SrgbConversion.perform(source)
+        VipsImageProcessor.new(srgb_converted_file_path || source, options).write_to_jpeg(target_path)
+      ensure
+        FileUtils.rm_f(srgb_converted_file_path) if srgb_converted_file_path
       end
     else
       ImageProcessor.new(source, options, local_options).tap(&:result).write_to_jpeg(target_path)

lib/morandi/profiled_pixbuf.rb

@@ -9,13 +9,16 @@ module Morandi
   # NOTE: pixbuf supports colour profiles, but it requires an explicit icc-profile option to embed it when saving file
   class ProfiledPixbuf < GdkPixbuf::Pixbuf
     def initialize(path, _local_options, max_size_px = nil)
-      path = srgb_path(path) || path
+      srgb_converted_file_path = srgb_path(path)
+      path = srgb_converted_file_path || path
 
       if max_size_px
         super(file: path, width: max_size_px, height: max_size_px)
       else
         super(file: path)
       end
+    ensure
+      FileUtils.rm_f(srgb_converted_file_path) if srgb_converted_file_path
     end
 
     private

lib/morandi/srgb_conversion.rb

@@ -13,7 +13,10 @@ def self.perform(path)
       icc_file_path = default_icc_path(path)
       system('jpgicc', '-q97', path, icc_file_path, out: '/dev/null', err: '/dev/null')
 
-      return unless valid_jpeg?(icc_file_path)
+      unless valid_jpeg?(icc_file_path)
+        FileUtils.rm_f(icc_file_path) # jpgicc likes to leave an empty file after failing
+        return
+      end
 
       icc_file_path
     end

lib/morandi/vips_image_processor.rb

@@ -55,8 +55,7 @@ def initialize(path, user_options)
     end
 
     def process!
-      srgb_converted_file_path = Morandi::SrgbConversion.perform(@path)
-      source_file_path = srgb_converted_file_path || @path
+      source_file_path = @path
       begin
         @img = Vips::Image.new_from_file(source_file_path)
       rescue Vips::Error => e

spec/morandi_spec.rb

@@ -45,10 +45,20 @@
     FileUtils.remove_dir('sample/')
   end
 
+  shared_examples 'tidy processor' do
+    it 'only leaves unchanged input, and a new output file with no other leftovers' do
+      expect { process_image }.to change { Dir['sample/*'].count }.by(1)
+
+      expect(File.exist?(file_in)).to eq true
+    end
+  end
+
   shared_examples 'an image processor' do |processor_name|
     let(:reference_image_prefix) { processor_name == 'pixbuf' ? '' : processor_name }
     subject(:process_image) { Morandi.process(file_arg, options, file_out, { 'processor' => processor_name }) }
 
+    it_behaves_like 'tidy processor'
+
     context 'when given an input without any options' do
       it 'creates output' do
         process_image
@@ -470,6 +480,8 @@
         generate_test_image_greyscale(file_in, width: original_image_width, height: original_image_height)
       end
 
+      it_behaves_like 'tidy processor'
+
       it 'changes greyscale image to srgb' do
         expect(file_in).to match_colourspace('gray') # Testing a setup to protect from a hidden regression
         process_image

spec/visual_report_helper.rb

@@ -68,8 +68,6 @@ def add_to_visual_report(example, files)
           fp.puts %(<pre>#{CGI.escapeHTML(JSON.pretty_generate(example.example_group_instance.options))}</pre>)
           fp.puts %(</td><td>)
           files.each.with_index do |filename, index|
-            next if File.basename(filename) == 'sample.jpg.icc.jpg'
-
             base = name_for(filename, example, index)
             FileUtils.cp(filename, "spec/reports/#{base}")
             fp << %(<div class="img-block"><img src="#{base}" style="max-width: 300px; height: auto;"><br>)