Skip to content

[IMPROVEMENT] chart: allow specifying spec.sampleLimit on ServiceMonitor #12671

@grelland

Description

@grelland

Is your improvement request related to a feature? Please describe (👍 if you like this request)

I would like to be able to specify spec.sampleLimit on the optional Prometheus ServiceMonitor.

Describe the solution you'd like

Add metrics.serviceMonitor.sampleLimit to values. Default value of 0 (unset).
Setting to a non-zero value will result in the value being set on spec.sampleLimit of the ServiceMonitor.

Describe alternatives you've considered

No response

Additional context

My current workaround is to not use the chart-provided ServiceMonitor, but rather implement and deploy my own instead. This works, but is an unnecessary hassle.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/improvementRequest for improvement of existing functionrequire/backportRequire backport. Only used when the specific versions to backport have not been definied.require/docRequire updating the longhorn.io documentationrequire/manual-test-planRequire adding/updating manual test cases if they can't be automated

    Projects

    Status

    New

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions