-
Notifications
You must be signed in to change notification settings - Fork 685
Open
Open
Copy link
Labels
kind/improvementRequest for improvement of existing functionRequest for improvement of existing functionrequire/backportRequire backport. Only used when the specific versions to backport have not been definied.Require backport. Only used when the specific versions to backport have not been definied.require/docRequire updating the longhorn.io documentationRequire updating the longhorn.io documentationrequire/manual-test-planRequire adding/updating manual test cases if they can't be automatedRequire adding/updating manual test cases if they can't be automated
Description
Is your improvement request related to a feature? Please describe (👍 if you like this request)
I would like to be able to specify spec.sampleLimit on the optional Prometheus ServiceMonitor.
Describe the solution you'd like
Add metrics.serviceMonitor.sampleLimit to values. Default value of 0 (unset).
Setting to a non-zero value will result in the value being set on spec.sampleLimit of the ServiceMonitor.
Describe alternatives you've considered
No response
Additional context
My current workaround is to not use the chart-provided ServiceMonitor, but rather implement and deploy my own instead. This works, but is an unnecessary hassle.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind/improvementRequest for improvement of existing functionRequest for improvement of existing functionrequire/backportRequire backport. Only used when the specific versions to backport have not been definied.Require backport. Only used when the specific versions to backport have not been definied.require/docRequire updating the longhorn.io documentationRequire updating the longhorn.io documentationrequire/manual-test-planRequire adding/updating manual test cases if they can't be automatedRequire adding/updating manual test cases if they can't be automated
Type
Projects
Status
New