add some output to SKILLS to more easily identify which skills are from skillsofts (#827)

add some output to SKILLS to more easily identify which skills are from skillsofts, and what your normal rank is (if any)

Author: scoutyoshimoto

src/act.comm.cpp

@@ -37,7 +37,7 @@ extern struct skill_data skills[];
 
 extern void respond(struct char_data *ch, struct char_data *mob, char *str);
 extern bool can_send_act_to_target(struct char_data *ch, bool hide_invisible, struct obj_data * obj, void *vict_obj, struct char_data *to, int type);
-extern char *how_good(int skill, int percent);
+extern char *how_good(int skill, int percent, bool chipped, int natural);
 extern const char *get_voice_perceived_by(struct char_data *speaker, struct char_data *listener, bool invis_staff_should_be_identified);
 int find_skill_num(char *name);
 void ring_phone(struct phone_data *k);
@@ -1670,7 +1670,9 @@ ACMD(do_language)
         continue;
 
       if ((GET_SKILL(ch, i)) > 0) {
-        snprintf(buf, sizeof(buf), "%-20s %-17s", skills[i].name, how_good(i, GET_SKILL(ch, i)));
+        snprintf(buf, sizeof(buf), "%-20s %-17s", skills[i].name,
+                 how_good(i, GET_SKILL(ch, i), GET_CHIPJACKED_SKILL(ch, i), GET_RAW_SKILL(ch, i))
+                );
         if (GET_LANGUAGE(ch) == i)
           strlcat(buf, " ^Y(Speaking)^n", sizeof(buf));
         strlcat(buf, "\r\n", sizeof(buf));

src/act.other.cpp

@@ -63,7 +63,7 @@ SPECIAL(shop_keeper);
 SPECIAL(spraypaint);
 SPECIAL(johnson);
 SPECIAL(anticoagulant);
-extern char *how_good(int skill, int percent);
+extern char *how_good(int skill, int percent, bool chipped, int natural);
 extern void perform_tell(struct char_data *, struct char_data *, char *);
 extern void obj_magic(struct char_data * ch, struct obj_data * obj, char *argument);
 extern void end_quest(struct char_data *ch, bool succeeded);
@@ -1620,7 +1620,9 @@ void _send_alphabetized_skills_to_ch(struct char_data *ch, const char *arg, int
       continue;
 
     if ((GET_SKILL(ch, i)) > 0) {
-      snprintf(buf2, sizeof(buf2), "%-40s %s\r\n", skills[i].name, how_good(i, GET_SKILL(ch, i)));
+      snprintf(buf2, sizeof(buf2), "%-40s %s\r\n", skills[i].name,
+               how_good(i, GET_SKILL(ch, i), GET_CHIPJACKED_SKILL(ch, i), GET_RAW_SKILL(ch, i))
+              );
       vec.push_back(std::string(buf2));
     }
   }

src/utils.cpp

@@ -4386,10 +4386,18 @@ const char *skill_rank_name(int rank, bool knowledge)
 #undef RANK_MESSAGE
 }
 
-char *how_good(int skill, int rank)
+char *how_good(int skill, int rank, bool chipped, int natural)
 {
+  static char practiced[256];
+  if (chipped && natural != 0) {
+    snprintf(practiced, sizeof(practiced), " (Practiced at rank ^c%2d^n)", natural);
+  }
   static char buf[256];
-  snprintf(buf, sizeof(buf), " (rank ^c%2d^n: %s)", rank, skill_rank_name(rank, skills[skill].is_knowledge_skill == SKILL_TYPE_KNOWLEDGE));
+  snprintf(buf, sizeof(buf), " (rank ^c%2d^n: %s%s)%s", rank,
+           skill_rank_name(rank, skills[skill].is_knowledge_skill == SKILL_TYPE_KNOWLEDGE),
+           chipped ? ", ^yChipped^n" : "",
+           chipped && natural != 0 ? practiced : ""
+          );
   return buf;
 }
 

src/utils.hpp

@@ -247,7 +247,7 @@ vnum_t vnum_from_gridguide_coordinates(long x, long y, struct char_data *ch, str
 struct veh_data *get_veh_controlled_by_char(struct char_data *ch);
 
 // Skill-related.
-char *how_good(int skill, int rank);
+char *how_good(int skill, int rank, bool chipped, int natural);
 const char *skill_rank_name(int rank, bool knowledge);
 void set_character_skill(struct char_data *ch, int skill_num, int new_value, bool send_message, bool save_immediately=TRUE);