[Issue] Fix DivisionByZeroError in creditmemo tax for zero base shipping amount

[m2-assistant]

This issue is automatically created based on existing pull request: #40467: Fix DivisionByZeroError in creditmemo tax for zero base shipping amount

---

Description

The collect() method in Magento\Sales\Model\Order\Creditmemo\Total\Tax has a partial guard at line 137 that checks $orderShippingAmount > 0 before dividing at line 139, but line 140 divides by $baseOrderShippingAmount without any zero-check.

When an order has free shipping (base_shipping_amount = 0), this causes a DivisionByZeroError at line 140:

$basePart = $creditmemo->getBaseShippingAmount() / $baseOrderShippingAmount;

This is inconsistent with line 109 in the same method, which correctly guards $baseOrderShippingAmount before dividing:

if ($baseOrderShippingAmount && $creditmemo->getBaseShippingAmount() !== null) {
    $taxFactor = $creditmemo->getBaseShippingAmount() / $baseOrderShippingAmount;

Steps to reproduce

1. Place an order with free shipping (shipping_amount = 0, base_shipping_amount = 0)
2. Create an invoice for the order
3. Trigger credit memo creation via CreditmemoFactory::createByOrder()
4. DivisionByZeroError is thrown at Tax.php:140

In production, this is triggered by the Stripe webhook retry cron (stripe_webhook_events_retry) when it attempts to cancel/refund an order with free shipping that has an existing invoice.

Expected result

Credit memo is created without error. When shipping amounts are zero, the shipping tax proportion block is skipped entirely (no shipping tax to apportion).

Actual result

DivisionByZeroError: Division by zero in vendor/magento/module-sales/Model/Order/Creditmemo/Total/Tax.php:140

This error repeats on every cron cycle, blocking webhook retry processing.

Fix

Add $baseOrderShippingAmount > 0 to the existing guard clause at line 137, so both divisors ($orderShippingAmount at line 139 and $baseOrderShippingAmount at line 140) are protected.

Related

The invoice path (line 109) already has the correct guard. This fix makes the non-invoice path consistent.

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @fceprika,

Thank you for the report and collaboration!

After going through with the code review for the said file in the description, it seems the issue can be reproducible on the given scenario. Hence confirming the issue for further processing.

Thank you