Skip to content

Commit af5860a

Browse files
author
Mateusz
committed
NFWMT Specs
1 parent 49998bf commit af5860a

File tree

2 files changed

+14
-7
lines changed

2 files changed

+14
-7
lines changed
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
11
{
22
"feature_name": "non-forwardable-message-tagging",
33
"created_at": "2025-12-29T15:38:46Z",
4-
"updated_at": "2025-12-29T17:21:03Z",
4+
"updated_at": "2025-12-29T17:40:12Z",
55
"language": "en",
6-
"phase": "design-generated",
6+
"phase": "tasks-generated",
77
"approvals": {
88
"requirements": {
99
"generated": true,
10-
"approved": false
10+
"approved": true
1111
},
1212
"design": {
1313
"generated": true,
14-
"approved": false
14+
"approved": true
1515
},
1616
"tasks": {
17-
"generated": false,
18-
"approved": false
17+
"generated": true,
18+
"approved": true
1919
}
2020
},
21-
"ready_for_implementation": false
21+
"ready_for_implementation": true
2222
}

.kiro/specs/non-forwardable-message-tagging/tasks.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@
9494

9595
- [ ] 5.2 (P) Tag server-generated command responses as never-forward
9696
- Tag the server-generated command response message as `never_forward` for the session at creation time.
97+
- Ensure the tag is persisted for the session lifetime as soon as the response is generated and before it is returned to the client.
9798
- Ensure recognition does not rely on client-preserved metadata if the client resubmits the response in history.
9899
- _Requirements: 3.1, 3.2, 3.3_
99100

@@ -107,6 +108,7 @@
107108
- [ ] 6.1 Register identity, registry, and enforcer services in staged initialization
108109
- Register new services with appropriate lifetimes and dependency wiring.
109110
- Ensure configuration values (tag capacity limit) are available to the registry at runtime.
111+
- Confirm services are available to command handling, steering injection, and backend orchestration in staged initialization order.
110112
- _Requirements: 1.1, 1.2, 1.3, 14.3_
111113

112114
- [ ] 6.2 Integrate enforcement into backend completion flow before capture and invocation
@@ -125,6 +127,7 @@
125127
- [ ]* 6.4 Add property-based tests for identity and filtering invariants (deferrable)
126128
- Generate diverse canonical message shapes (role/content/tool variants) and assert identity determinism.
127129
- Assert filtering invariants (order preserved; removed messages are always tagged for the session and scope).
130+
- Include cases covering tool-result messages whose content is rewritten by compaction.
128131
- _Requirements: 1.2, 1.5, 5.2_
129132

130133
- [ ] 7. Ensure coverage across entry points and session identity propagation (Option B)
@@ -143,11 +146,13 @@
143146
- [ ] 7.3 Ensure internal retry/steering workflows propagate session id and injection provenance
144147
- Reuse the same session id across multiple backend calls made within a single logical interaction.
145148
- Provide the injected-message provenance boundary for every backend call that appends steering/internal messages.
149+
- Confirm internal workflows never bypass the shared enforcement boundary.
146150
- _Requirements: 7.2, 8.2, 8.3_
147151

148152
- [ ] 7.4 Add integration tests for session scoping and non-leakage across entry points
149153
- Verify tags are applied only within the resolved session id and do not leak across sessions.
150154
- Verify a non-HTTP entry point reuses the same session id across multiple backend calls in a single interaction.
155+
- Verify concurrent interactions do not cross-apply tags between different session identifiers.
151156
- _Requirements: 8.1, 8.2, 8.3, 8.4_
152157

153158
- [ ] 8. Remove legacy regex-based enforcement and legacy code paths (alpha finality)
@@ -160,9 +165,11 @@
160165
- [ ] 8.2 Update tests to remove legacy regex expectations and assert final behavior only
161166
- Remove or rewrite tests that depended on legacy regex stripping and replace with tagging/enforcement assertions.
162167
- Add regression coverage that fails if legacy regex-based non-forwardable filtering is reintroduced.
168+
- Remove obsolete helpers/fixtures that existed only to support legacy regex-based enforcement tests.
163169
- _Requirements: 13.1, 13.3_
164170

165171
- [ ] 8.3 Run the full unit and integration suites for this feature and fix failures
166172
- Ensure unit tests for identity/registry/enforcer pass.
167173
- Ensure integration tests for backend flow, compaction compatibility, and entry point coverage pass.
174+
- Ensure static checks pass for modified modules (lint, formatting, type checks).
168175
- _Requirements: 9.1, 10.1, 11.1_

0 commit comments

Comments
 (0)