fix more unit tests

Author: diosmosis

classes/WpMatomo/AIBotTracking.php

@@ -142,7 +142,10 @@ public function should_track_current_page() {
 			return false;
 		}
 
-		if ( empty( $_SERVER['REQUEST_URI'] ) ) {
+		if (
+			! array_key_exists( 'REQUEST_URI', $_SERVER )
+			|| null === $_SERVER['REQUEST_URI']
+		) {
 			return false;
 		}
 

tests/phpunit/wpmatomo/test-ai-bot-tracking.php

@@ -87,7 +87,7 @@ public function test_should_track_current_page_returns_false_for_admin_pages() {
 	public function test_should_track_current_page_returns_false_if_no_request_uri_is_set() {
 		$this->enable_ai_bot_tracking();
 
-		$this->unset_current_url();
+		unset( $_SERVER['REQUEST_URI'] );
 
 		$should_track = $this->ai_bot_tracking->should_track_current_page();
 		$this->assertFalse( $should_track );

tests/phpunit/wpmatomo/test-annotations.php

@@ -83,7 +83,7 @@ public function test_add_annotation_when_post_type_allowed() {
 					'id'              => 1,
 					'idsite'          => 1,
 					'date'            => gmdate( 'Y-m-d' ),
-					'note'            => 'Published: hello-world - URL: https://example.org/?p=' . $post->ID,
+					'note'            => 'Published: hello-world - URL: http://example.org/?p=' . $post->ID,
 					'starred'         => 0,
 					'user'            => 'super user was set',
 					'canEditOrDelete' => true,

tests/phpunit/wpmatomo/test-install.php

@@ -84,7 +84,7 @@ public function test_install_adds_sites_and_users() {
 				array(
 					'idsite'                         => 1,
 					'name'                           => 'Test Blog',
-					'main_url'                       => 'https://example.org',
+					'main_url'                       => 'http://example.org',
 					'ecommerce'                      => 1,
 					'sitesearch'                     => 1,
 					'sitesearch_keyword_parameters'  => '',

tests/phpunit/wpmatomo/test-paths.php

@@ -75,19 +75,19 @@ public function test_get_matomo_js_upload_path() {
 	}
 
 	public function test_get_tracker_api_rest_api_endpoint() {
-		$this->assertSame( 'https://' . WP_TESTS_DOMAIN . '/index.php?rest_route=/matomo/v1/hit/', $this->paths->get_tracker_api_rest_api_endpoint() );
+		$this->assertSame( 'http://' . WP_TESTS_DOMAIN . '/index.php?rest_route=/matomo/v1/hit/', $this->paths->get_tracker_api_rest_api_endpoint() );
 	}
 
 	public function test_get_js_tracker_rest_api_endpoint() {
-		$this->assertSame( 'https://' . WP_TESTS_DOMAIN . '/index.php?rest_route=/matomo/v1/hit/', $this->paths->get_js_tracker_rest_api_endpoint() );
+		$this->assertSame( 'http://' . WP_TESTS_DOMAIN . '/index.php?rest_route=/matomo/v1/hit/', $this->paths->get_js_tracker_rest_api_endpoint() );
 	}
 
 	public function test_get_tracker_api_url_in_matomo_dir() {
-		$this->assertSame( 'https://' . WP_TESTS_DOMAIN . '/wp-content/plugins/matomo/app/matomo.php', $this->paths->get_tracker_api_url_in_matomo_dir() );
+		$this->assertSame( 'http://' . WP_TESTS_DOMAIN . '/wp-content/plugins/matomo/app/matomo.php', $this->paths->get_tracker_api_url_in_matomo_dir() );
 	}
 
 	public function test_get_js_tracker_url_in_matomo_dir() {
-		$this->assertSame( 'https://' . WP_TESTS_DOMAIN . '/wp-content/plugins/matomo/app/matomo.js', $this->paths->get_js_tracker_url_in_matomo_dir() );
+		$this->assertSame( 'http://' . WP_TESTS_DOMAIN . '/wp-content/plugins/matomo/app/matomo.js', $this->paths->get_js_tracker_url_in_matomo_dir() );
 	}
 
 	public function test_get_config_ini_path() {

tests/phpunit/wpmatomo/test-privacybadge.php

@@ -15,7 +15,7 @@ public function setUp(): void {
 	}
 
 	public function test_privacy_badge_shortcode_no_options() {
-		$this->assertSame( '<img alt="Your privacy protected! This website uses Matomo." src="https://example.org/wp-content/plugins/matomo/assets/img/privacybadge.png"  width="120" height="120">', do_shortcode( '[matomo_privacy_badge]' ) );
+		$this->assertSame( '<img alt="Your privacy protected! This website uses Matomo." src="http://example.org/wp-content/plugins/matomo/assets/img/privacybadge.png"  width="120" height="120">', do_shortcode( '[matomo_privacy_badge]' ) );
 	}
 
 	public function test_privacy_badge_shortcode_size() {

tests/phpunit/wpmatomo/test-trackingcode.php

@@ -210,7 +210,7 @@ public function test_add_feed_tracking() {
 
 		$url = apply_filters( 'the_excerpt_rss', '<p>foobarbaz</p>' );
 
-		$this->assertStringStartsWith( '<p>foobarbaz</p><img src="//example.org/index.php?rest_route=/matomo/v1/hit/?idsite=23&amp;rec=1&amp;url=https%3A%2F%2Fexample.org%2F%3Fp%3D' . $post->ID . '&amp;action_name=hello-world&amp;urlref=https%3A%2F%2Fexample.org', $url );
+		$this->assertStringStartsWith( '<p>foobarbaz</p><img src="//example.org/index.php?rest_route=/matomo/v1/hit/?idsite=23&amp;rec=1&amp;url=http%3A%2F%2Fexample.org%2F%3Fp%3D' . $post->ID . '&amp;action_name=hello-world&amp;urlref=http%3A%2F%2Fexample.org', $url );
 		$this->assertStringEndsWith( '" style="border:0;width:0;height:0" width="0" height="0" alt="" />', $url );
 	}