Skip to content
This repository was archived by the owner on Oct 30, 2022. It is now read-only.
This repository was archived by the owner on Oct 30, 2022. It is now read-only.

Merge service.ts and serviceCore.ts #345

@mikesol

Description

@mikesol

The separation of service.ts and serviceCore.ts used to make sense when service was used as a public wrapper around service core, but as the two evolved, they became pretty co-dependent and indistinguishable. I do not see any blockers to merging them, but there could be some distinctions between the two in the code base that need to be preserved.

It would be good to investigate how service and serviceCore are being called, note any meaningful distinctions, and either make these more apparent through better comments/interfaces or, if the distinctions do not warrant two separate files, merge the files.

Metadata

Metadata

Assignees

Labels

refactoringHousekeeping and pruning

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions