Skip to content

Commit d222784

Browse files
committed
fix(api): update response status and schema for DeleteAgentSkill endpoint
1 parent 0f145c9 commit d222784

File tree

6 files changed

+26
-12
lines changed

6 files changed

+26
-12
lines changed

docs/api-reference/openapi.json

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,15 @@
122122
}
123123
} ],
124124
"responses" : {
125-
"204" : {
126-
"content" : { },
127-
"description" : ""
125+
"200" : {
126+
"content" : {
127+
"application/json" : {
128+
"schema" : {
129+
"$ref" : "#/components/schemas/serializer.Response"
130+
}
131+
}
132+
},
133+
"description" : "OK"
128134
}
129135
},
130136
"security" : [ {

src/server/api/go/docs/docs.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,11 @@ const docTemplate = `{
253253
}
254254
],
255255
"responses": {
256-
"204": {
257-
"description": ""
256+
"200": {
257+
"description": "OK",
258+
"schema": {
259+
"$ref": "#/definitions/serializer.Response"
260+
}
258261
}
259262
},
260263
"x-code-samples": [

src/server/api/go/docs/swagger.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,8 +250,11 @@
250250
}
251251
],
252252
"responses": {
253-
"204": {
254-
"description": ""
253+
"200": {
254+
"description": "OK",
255+
"schema": {
256+
"$ref": "#/definitions/serializer.Response"
257+
}
255258
}
256259
},
257260
"x-code-samples": [

src/server/api/go/docs/swagger.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -768,8 +768,10 @@ paths:
768768
produces:
769769
- application/json
770770
responses:
771-
"204":
772-
description: ""
771+
"200":
772+
description: OK
773+
schema:
774+
$ref: '#/definitions/serializer.Response'
773775
security:
774776
- BearerAuth: []
775777
summary: Delete agent skill

src/server/api/go/internal/modules/handler/agent_skills.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ func (h *AgentSkillsHandler) GetAgentSkill(c *gin.Context) {
151151
// @Produce json
152152
// @Param id path string true "Agent skill UUID"
153153
// @Security BearerAuth
154-
// @Success 204 ""
154+
// @Success 200 {object} serializer.Response
155155
// @Router /agent_skills/{id} [delete]
156156
// @x-code-samples [{"lang":"python","source":"from acontext import AcontextClient\n\nclient = AcontextClient(api_key='sk_project_token')\n\n# Delete a skill by ID\nclient.skills.delete('skill-uuid-here')\nprint('Skill deleted successfully')\n","label":"Python"},{"lang":"javascript","source":"import { AcontextClient } from '@anthropic/acontext';\n\nconst client = new AcontextClient({ apiKey: 'sk_project_token' });\n\n// Delete a skill by ID\nawait client.skills.delete('skill-uuid-here');\nconsole.log('Skill deleted successfully');\n","label":"JavaScript"}]
157157
func (h *AgentSkillsHandler) DeleteAgentSkill(c *gin.Context) {
@@ -172,7 +172,7 @@ func (h *AgentSkillsHandler) DeleteAgentSkill(c *gin.Context) {
172172
return
173173
}
174174

175-
c.Status(http.StatusNoContent)
175+
c.JSON(http.StatusOK, serializer.Response{})
176176
}
177177

178178
type ListAgentSkillsReq struct {

src/server/api/go/internal/modules/handler/agent_skills_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@ func TestAgentSkillsHandler_DeleteAgentSkill(t *testing.T) {
482482
setup: func(svc *MockAgentSkillsService) {
483483
svc.On("Delete", mock.Anything, projectID, agentSkillsID).Return(nil)
484484
},
485-
expectedStatus: http.StatusNoContent,
485+
expectedStatus: http.StatusOK,
486486
},
487487
{
488488
name: "invalid ID",

0 commit comments

Comments
 (0)