Fixed a bug: created a mechanism to prevent feedback between slider changes and brightness updates from the service.

Author: DIMFLIX

src/mewline/widgets/combined_controls.py

@@ -30,6 +30,9 @@ def __init__(self, anchor_widget: GObject.GObject, osd_widget=None, **kwargs):
         self.config = cfg.modules
         self.osd_widget = osd_widget
 
+        self._updating_brightness_from_service = False
+        self._updating_brightness = False
+
         # Check if brightness control is available
         self.brightness_available = self._is_brightness_available()
 
@@ -253,7 +256,7 @@ def _bind_microphone(self, *_):
             self._update_mic_from_service()
 
     def _on_brightness_service(self, *_):
-        if not self.brightness_available or self._brightness_apply_src:
+        if not self.brightness_available or self._brightness_apply_src or self._updating_brightness_from_service:
             return  # Don't update while we have a pending change
         val = self._get_brightness()
         self.brightness_scale.set_value(val)
@@ -346,6 +349,8 @@ def _apply_mic(self):
     def _apply_brightness(self):
         if not self.brightness_available:
             return False
+
+        self._updating_brightness_from_service = True
         val = int(self.brightness_scale.value)
         val = max(0, min(100, val))
         # translate percent back to raw units
@@ -355,6 +360,12 @@ def _apply_brightness(self):
         if self.osd_widget:
             self.osd_widget.show_brightness()
         self._brightness_apply_src = None
+
+        GLib.timeout_add(100, self.unblock_service_updates)
+        return False
+
+    def _unblock_service_updates(self):
+        self._updating_brightness_from_service = False
         return False
 
 
@@ -513,11 +524,14 @@ def _apply_scroll_updates(self):
                 if self.osd_widget:
                     self.osd_widget.show_audio_microphone()
             elif device == "brightness" and self._is_brightness_available():
+                self._updating_brightness = True
                 target = int((value / 100.0) * self.brightness.max_brightness_level)
                 self.brightness.screen_brightness = target
                 if self.osd_widget:
                     self.osd_widget.show_brightness()
 
+                GLib.timeout_add(100, lambda: setattr(self, '_updating_brightness', False))
+
         self._pending_scroll_updates.clear()
         self._scroll_debounce_src = None
         return False
@@ -564,7 +578,7 @@ def _bind_microphone(self, *_):
             self._update_mic_icon()
 
     def _on_brightness_changed(self, *_):
-        if self._is_brightness_available():
+        if self._is_brightness_available() and not self._updating_brightness:
             self.icon_brightness.set_text(get_brightness_icon(self._get_brightness()))
 
     def _update_speaker_icon(self, *_):

whitelist-vulture

@@ -1,27 +1,24 @@
 XDG_STATE_HOME  # unused variable (src/mewline/constants.py:14)
 _._duration  # unused attribute (src/mewline/shared/animator.py:76)
-step_size  # unused variable (src/mewline/utils/config_structure.py:61)
-step_size  # unused variable (src/mewline/utils/config_structure.py:67)
-step_size  # unused variable (src/mewline/utils/config_structure.py:79)
-speakers  # unused variable (src/mewline/utils/config_structure.py:129)
 _.rowstride  # unused attribute (src/mewline/utils/temporary_fixes.py:29)
 _.has_alpha  # unused attribute (src/mewline/utils/temporary_fixes.py:30)
 _.bits_per_sample  # unused attribute (src/mewline/utils/temporary_fixes.py:31)
 _.channels  # unused attribute (src/mewline/utils/temporary_fixes.py:32)
 _._pixbuf  # unused attribute (src/mewline/utils/temporary_fixes.py:43)
 _.byte_array  # unused attribute (src/mewline/utils/temporary_fixes.py:44)
-_.xalign  # unused attribute (src/mewline/widgets/dynamic_island/app_launcher.py:52)
+_.xalign  # unused attribute (src/mewline/widgets/dynamic_island/app_launcher.py:59)
 _.xalign  # unused attribute (src/mewline/widgets/dynamic_island/clipboard.py:59)
 _.xalign  # unused attribute (src/mewline/widgets/dynamic_island/emoji.py:57)
 _.xalign  # unused attribute (src/mewline/widgets/dynamic_island/pawlette_themes.py:81)
 _.xalign  # unused attribute (src/mewline/widgets/dynamic_island/wallpapers.py:159)
 _.toggle_shuffle  # unused method (src/mewline/services/mpris.py:87)
 _.set_pointing_to  # unused method (src/mewline/shared/popover.py:107)
 _.set_content  # unused method (src/mewline/shared/popover.py:110)
+_._unblock_service_updates  # unused method (src/mewline/widgets/combined_controls.py:367)
 _.show_for_device  # unused method (src/mewline/widgets/osd.py:158)
 _.get_profile_icon  # unused method (src/mewline/services/battery.py:176)
 popover_opened  # unused function (src/mewline/shared/popover.py:76)
 popover_closed  # unused function (src/mewline/shared/popover.py:82)
 _.stop  # unused method (src/mewline/shared/animator.py:174)
 _.return_popover_window  # unused method (src/mewline/shared/popover.py:60)
-_._detach_nav  # unused method (src/mewline/widgets/dynamic_island/notifications.py:525)
+_._detach_nav  # unused method (src/mewline/widgets/dynamic_island/notifications.py:555)