fix: remove parens from cols in buildUnnest()

Author: mhweiner

docs/api.md

@@ -240,18 +240,23 @@ const unnestUsers = buildUnnest<User>({
     type: 'timestamptz',
     transform: (user) => new Date(user.dateRegistered), // optional custom transform
   },
-  teamId: {type: 'int4'},
+  teamId: {type: 'int'},
 });
 
 // 3. Build the query
 
 const {cols, unnest, values} = unnestUsers(users);
 const text = `
-    INSERT INTO users ${cols}
+    INSERT INTO users (${cols})
     SELECT * FROM ${unnest}
     ON CONFLICT (id) DO NOTHING
     `;
 
+// This will generate the following SQL:
+// INSERT INTO users ("id", "dateRegistered", "teamId")
+// SELECT * FROM UNNEST($1::uuid[], $2::timestamptz[], $3::int4[])
+// ON CONFLICT (id) DO NOTHING
+
 await db.query({text, values});
 ```
 

src/buildUnnest.spec.ts

@@ -25,7 +25,7 @@ test('buildUnnest returns correct cols, unnest, and values', async (assert) => {
   return assert.equal(
       JSON.stringify({cols, unnest, values}),
       JSON.stringify({
-          cols: '("id", "time", "level")',
+          cols: '"id", "time", "level"',
           unnest: 'UNNEST($1::uuid[], $2::timestamptz[], $3::int[]) AS t("id", "time", "level")',
           values: [
               ['a', 'b'],
@@ -54,7 +54,7 @@ test('buildUnnest works with default accessors', async (assert) => {
   return assert.equal(
       JSON.stringify({cols, unnest, values}),
       JSON.stringify({
-          cols: '("a", "b")',
+          cols: '"a", "b"',
           unnest: 'UNNEST($1::int[], $2::text[]) AS t("a", "b")',
           values: [[1, 2], ['one', 'two']],
       })
@@ -79,7 +79,7 @@ test('buildUnnest handles nulls and missing values safely', async (assert) => {
   return assert.equal(
       JSON.stringify({cols, unnest, values}),
       JSON.stringify({
-          cols: '("name", "note")',
+          cols: '"name", "note"',
           unnest: 'UNNEST($1::text[], $2::text[]) AS t("name", "note")',
           values: [['Alice', 'Bob'], [null, 'hi']],
       })

src/buildUnnest.ts

@@ -8,7 +8,7 @@ type SchemaEntry<T> = {
 };
 type SchemaSpec<T> = Record<keyof T, SchemaEntry<T>>;
 type UnnestResult = {
-    cols: string // e.g. ("id", "time", "level")
+    cols: string // e.g. "id", "time", "level"
     unnest: string // e.g. UNNEST($1::uuid[], ...) AS t("id", "time", ...)
     values: any[][] // column-aligned arrays
 };
@@ -59,14 +59,11 @@ export function buildUnnest<T>(spec: SchemaSpec<T>): (rows: T[]) => UnnestResult
         }
 
         const values: any[][] = keys.map((key) => cols[key]);
-
-        const colList = `(${keys.map((k) => `"${k}"`).join(', ')})`;
-
+        const colList = `${keys.map((k) => `"${k}"`).join(', ')}`;
         const unnestList = keys
             .map((key, i) => `$${i + 1}::${types[key]}[]`)
             .join(', ');
-
-        const unnest = `UNNEST(${unnestList}) AS t${colList}`;
+        const unnest = `UNNEST(${unnestList}) AS t(${colList})`;
 
         return {
             cols: colList,