Skip to content

Commit 4c678df

Browse files
authored
Fix typos and update labels for Northern Ireland and XI in CreateCountryRegion codeunit (#29666)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to AlAppExtensions please read our pull request guideline below * https://github.com/microsoft/ALAppExtensions/blob/main/CONTRIBUTING.md --> #### Summary <!-- Provide a general summary of your changes --> This pull request updates the demo data setup for country and region creation, specifically correcting the label and token for Northern Ireland. The changes ensure proper naming and coding conventions for country/region identifiers and labels. **Corrections for Northern Ireland:** * Renamed the label from `NothernIrelandLbl` to `NorthernIrelandLbl` to fix a spelling error. * Replaced the country token from `GBNTok` (GBN) to `XITok` (XI) for Northern Ireland, aligning with standard country/region codes. * Updated the country/region insertion logic to use the corrected label and token for Northern Ireland. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes #29496 Fixes [AB#621128](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/621128)
1 parent 8786d37 commit 4c678df

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Apps/W1/ContosoCoffeeDemoDataset/app/DemoData/Foundation/1.Setup data/CreateCountryRegion.Codeunit.al

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ codeunit 5205 "Create Country/Region"
6060
ContosoCountryOrRegion.InsertCountryOrRegion(MY(), MalaysiaLbl, '458', '', '', Enum::"Country/Region Address Format"::"Post Code+City", 1, '', '');
6161
ContosoCountryOrRegion.InsertCountryOrRegion(MZ(), MozambiqueLbl, '508', '', '', Enum::"Country/Region Address Format"::"Post Code+City", 1, '', '');
6262
ContosoCountryOrRegion.InsertCountryOrRegion(NG(), NigeriaLbl, '566', '', '', Enum::"Country/Region Address Format"::"City+Post Code", 1, '', '');
63-
ContosoCountryOrRegion.InsertCountryOrRegion(NI(), NothernIrelandLbl, CopyStr(GB(), 1, 2), '826', GBNTok, GBNTok, Enum::"Country/Region Address Format"::"City+County+Post Code", 1, '9932', '');
63+
ContosoCountryOrRegion.InsertCountryOrRegion(NI(), NorthernIrelandLbl, CopyStr(GB(), 1, 2), '826', XITok, XITok, Enum::"Country/Region Address Format"::"City+County+Post Code", 1, '9932', '');
6464
ContosoCountryOrRegion.InsertCountryOrRegion(NL(), NetherlandsLbl, '528', NLTok, NLTok, Enum::"Country/Region Address Format"::"Post Code+City", 1, '9944', '');
6565
ContosoCountryOrRegion.InsertCountryOrRegion(NO(), NorwayLbl, '578', '', '', Enum::"Country/Region Address Format"::"Post Code+City", 1, '0192', '');
6666
ContosoCountryOrRegion.InsertCountryOrRegion(NZ(), NewZealandLbl, '554', '', '', Enum::"Country/Region Address Format"::"City+Post Code", 1, '', '');
@@ -497,7 +497,7 @@ codeunit 5205 "Create Country/Region"
497497
VUTok: Label 'VU', MaxLength = 10, Locked = true;
498498
WSTok: Label 'WS', MaxLength = 10, Locked = true;
499499
ZATok: Label 'ZA', MaxLength = 10, Locked = true;
500-
GBNTok: Label 'GBN', MaxLength = 10, Locked = true;
500+
XITok: Label 'XI', MaxLength = 10, Locked = true;
501501
UnitedArabEmiratesLbl: Label 'United Arab Emirates', MaxLength = 50;
502502
AustriaLbl: Label 'Austria', MaxLength = 50;
503503
AustraliaLbl: Label 'Australia', MaxLength = 50;
@@ -540,7 +540,7 @@ codeunit 5205 "Create Country/Region"
540540
MalaysiaLbl: Label 'Malaysia', MaxLength = 50;
541541
MozambiqueLbl: Label 'Mozambique', MaxLength = 50;
542542
NigeriaLbl: Label 'Nigeria', MaxLength = 50;
543-
NothernIrelandLbl: Label 'Nothern Ireland', MaxLength = 50;
543+
NorthernIrelandLbl: Label 'Northern Ireland', MaxLength = 50;
544544
NetherlandsLbl: Label 'Netherlands', MaxLength = 50;
545545
NorwayLbl: Label 'Norway', MaxLength = 50;
546546
NewZealandLbl: Label 'New Zealand', MaxLength = 50;

0 commit comments

Comments
 (0)