Refine

Author: crickman

dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/ObjectModel/CopyConversationMessagesExecutor.cs

@@ -42,14 +42,11 @@ internal sealed class CopyConversationMessagesExecutor(CopyConversationMessages
 
     private IEnumerable<ChatMessage>? GetInputMessages()
     {
-        DataValue? messages = null;
+        Throw.IfNull(this.Model.Messages, $"{nameof(this.Model)}.{nameof(this.Model.Messages)}");
 
-        if (this.Model.Messages is not null)
-        {
-            EvaluationResult<DataValue> expressionResult = this.Evaluator.GetValue(this.Model.Messages);
-            messages = expressionResult.Value;
-        }
+        EvaluationResult<DataValue> expressionResult = this.Evaluator.GetValue(this.Model.Messages);
+        DataValue messages = expressionResult.Value;
 
-        return messages?.ToChatMessages();
+        return messages.ToChatMessages();
     }
 }

dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/CopyConversationMessagesExecutorTest.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft. All rights reserved.
+// Copyright (c) Microsoft. All rights reserved.
 
 using System.Collections.Generic;
 using System.Linq;
@@ -33,7 +33,7 @@ await this.ExecuteTestAsync(
     public async Task CopyMessagesWithSingleRecordMessageAsync()
     {
         // Arrange
-        ChatMessage testMessage = new ChatMessage(ChatRole.User, "Test message content");
+        ChatMessage testMessage = new(ChatRole.User, "Test message content");
         DataValue messageDataValue = testMessage.ToRecord().ToDataValue();
         Assert.IsType<RecordDataValue>(messageDataValue);
         RecordDataValue messageRecord = (RecordDataValue)messageDataValue;