Skip to content

fix(children directive): Capture target via closure to fix NgZone compatibility #7241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mich0608 wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −8
Open

fix(children directive): Capture target via closure to fix NgZone compatibility #7241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
240f75d
Moves handleEvent from a class property into a closure to remove non-…
Dec 19, 2025
5a6d536
Change files
Dec 19, 2025
d4ae70f
Merge branch 'main' into fix/observer-target-reference
Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@microsoft-fast-element-74afe8a2-ec05-4780-8034-5c2ea436d82e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Moves handleEvent from a class property into a closure in children.ts to remove non-standard observer.target property assignment",
"packageName": "@microsoft/fast-element",
"email": "email not defined",
"dependentChangeType": "none"
}
12 changes: 4 additions & 8 deletions packages/fast-element/src/templating/children.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,14 @@ export class ChildrenDirective extends NodeObservationDirective<ChildrenDirectiv
let observer = target[this.observerProperty];

if (!observer) {
observer = new MutationObserver(this.handleEvent);
const handleEvent = (mutations, observer) => {
this.updateTarget(this.getSource(target), this.computeNodes(target));
};
observer = new MutationObserver(handleEvent);
observer.toJSON = noop;
target[this.observerProperty] = observer;
}

observer.target = target;
observer.observe(target, this.options);
}

Expand All @@ -77,7 +79,6 @@ export class ChildrenDirective extends NodeObservationDirective<ChildrenDirectiv
*/
disconnect(target: any): void {
const observer = target[this.observerProperty];
observer.target = null;
observer.disconnect();
}

Expand All @@ -92,11 +93,6 @@ export class ChildrenDirective extends NodeObservationDirective<ChildrenDirectiv

return Array.from(target.childNodes);
}

private handleEvent = (mutations: MutationRecord[], observer: any): void => {
const target = observer.target;
this.updateTarget(this.getSource(target), this.computeNodes(target));
};
}

HTMLDirective.define(ChildrenDirective);
Expand Down