Old window gains focus and moves to foreground when opening new window in `NavigationView.ItemInvoked`

[Scighost]

Describe the bug

When handling the NavigationView.ItemInvoked event to open a new window, the old window unexpectedly regains focus and moves to the foreground after the new window is shown. This disrupts the user experience as the old window should remain in its current state and not interfere with the new window. However, this issue does not occur when opening a new window inside the NavigationViewItem.Tapped event.

Steps to reproduce the bug

<Window x:Class="App.MainWindow">
    <NavigationView ItemInvoked="NavigationView_ItemInvoked">
        <NavigationView.PaneHeader>
            <NavigationViewItem Content="Tapped"
                                Icon="Accept"
                                Tapped="NavigationViewItem_Tapped" />
        </NavigationView.PaneHeader>
        <NavigationView.MenuItems>
            <NavigationViewItem Content="ItemInvoked" Icon="Cancel" />
        </NavigationView.MenuItems>
    </NavigationView>
</Window>

private void NavigationView_ItemInvoked(NavigationView sender, NavigationViewItemInvokedEventArgs args)
{
    new MainWindow().Activate();
}

private void NavigationViewItem_Tapped(object sender, TappedRoutedEventArgs e)
{
    new MainWindow().Activate();
}

Expected behavior

The new window should open and gain focus without affecting the old window's focus or Z-order.

Screenshots

bug.mp4

NuGet package version

WinUI 3 - Windows App SDK 1.6.3: 1.6.241114003

Windows version

Windows 11 (23H2): Build 22631

Additional context

No response

[karkarl]

This looks like an issue on the Activated method on the Window class, not NavigationView.

[zadjii-msft]

Yea, I'm seeing the same thing in my own app, though I'm seeing it in a ListViewItem.DoubleTapped handler. Curiously, a ListView.ItemClicked or just a plain old ListViewItem.Tapped doesn't hit this?

[Lightczx]

@Scighost
see L#2693

microsoft-ui-xaml/src/controls/dev/NavigationView/NavigationView.cpp

Lines 2690 to 2694 in 589ced4

	void NavigationView::OnNavigationViewItemClicked(const winrt::NavigationViewItem& sender)
	{
	OnNavigationViewItemInvoked(sender);
	sender.Focus(winrt::FocusState::Pointer);
	}

I guess you should delay the window creation

[torum]

This bug just bit me too.

I found a workaround. In my case, its ItemsView's ItemInvoked (and DoubleTapped for ListView also has this bug), but I think its pretty much the same for NavigationView's ItemInvoked.

I realized that when I "invoked" an item by double clicking, the window showed up before the last mouse "pointer release" event. And the main window got focused after the second/last mouse "pointer release" event. So, it looked like the last mouse "pointer release" event stole the focus.

So, I added e.Handled = true; on PointerPressed event and it worked. Originally, I try to delay the window creation like someone else said, but it does not always work because it relies on timing of PointerReleased event. Also, AllowFocusOnInteraction="False" does not work either.

XAML:

<ItemsView ItemInvoked="ItemsView_ItemInvoked">
    <ItemsView.ItemTemplate>
        <DataTemplate x:DataType="...">
            <ItemContainer PointerPressed="ItemContainer_PointerPressed" PointerReleased="ItemContainer_PointerReleased">
...
            </ItemContainer>
        </DataTemplate>
    </ItemsView.ItemTemplate>
</ItemsView>

Code behind:

    private void ItemContainer_PointerPressed(object sender, Microsoft.UI.Xaml.Input.PointerRoutedEventArgs e)
    {
        e.Handled = true;
    }
    private void ItemContainer_PointerReleased(object sender, Microsoft.UI.Xaml.Input.PointerRoutedEventArgs e)
    {
        e.Handled = true;
    }
    private void ItemsView_ItemInvoked(ItemsView sender, ItemsViewItemInvokedEventArgs args)
    {
        // Create and show new window
    }

Reference:
#8087
#8520
#5411