Re-Entrancy in ApplicationDataProvider::GetStateFolderUris

[brianrob]

Describe the bug

The application crashes due to re-entrancy:

00 000000dd0316ccb0 00007ff875df3fc9 KERNELBASE!RaiseFailFastException+0x152

01 000000dd0316d290 00007fff9fdd5295 combase!RoFailFastWithErrorContextInternal2+0x4d9 [onecore\com\combase\winrt\error\error.cpp @ 1468]

02 000000dd0316d500 00007fff9fd4fece Microsoft_ui_xaml!FailFastWithStowedExceptions+0x59 [C:__w\1\s\dxaml\xcp\components\base\ErrorContext.cpp @ 1508]

03 000000dd0316d530 00007fff9fb3ad58 Microsoft_ui_xaml!CXcpDispatcher::OnReentrancyProtectedWindowMessage+0x21464e [C:__w\1\s\dxaml\xcp\win\shared\xcpwindow.cpp @ 666]

04 000000dd0316d5b0 00007fff9fb3ac39 Microsoft_ui_xaml!CDeferredInvoke::DispatchQueuedMessage+0xc8 [C:__w\1\s\dxaml\xcp\win\shared\xcpwindow.cpp @ 147]

05 (Inline Function) --------`-------- Microsoft_ui_xaml!CXcpDispatcher::MessageTimerCallback+0x59 [C:__w\1\s\dxaml\xcp\win\shared\xcpwindow.cpp @ 1213]

06 (Inline Function) --------`-------- Microsoft_ui_xaml!CXcpDispatcher::MessageTimerCallbackStatic+0x5d [C:__w\1\s\dxaml\xcp\win\shared\xcpwindow.cpp @ 1203]

07 (Inline Function) --------`-------- Microsoft_ui_xaml!CXcpDispatcher::Init::__l46::<lambda_1>::operator()+0x5d [C:__w\1\s\dxaml\xcp\win\shared\xcpwindow.cpp @ 313]

08 000000dd0316d670 00007ff825ad8057 Microsoft_ui_xaml!Microsoft::WRL::Details::DelegateArgTraits<long (__cdecl ABI::Windows::Foundation::ITypedEventHandler_impl<ABI::Windows::Foundation::Internal::AggregateType<ABI::Microsoft::UI::Dispatching::DispatcherQueueTimer *,ABI::Microsoft::UI::Dispatching::IDispatcherQueueTimer *>,IInspectable >::)(ABI::Microsoft::UI::Dispatching::IDispatcherQueueTimer *,IInspectable *)>::DelegateInvokeHelper<Microsoft::WRL::Implements<Microsoft::WRL::RuntimeClassFlags<2>,ABI::Windows::Foundation::ITypedEventHandler<ABI::Microsoft::UI::Dispatching::DispatcherQueueTimer *,IInspectable *>,Microsoft::WRL::FtmBase>,CXcpDispatcher::Init'::46'::<lambda_1> &,1,ABI::Microsoft::UI::Dispatching::IDispatcherQueueTimer *,IInspectable *>::Invoke+0x79 [C:__w\1\s\packages\Microsoft.Windows.SDK.cpp.10.0.22621.755\c\Include\10.0.22621.0\winrt\wrl\event.h @ 354]

09 000000dd0316d700 00007ff825ad33df CoreMessagingXP!Microsoft::WRL::Details::DelegateArgTraits<long (__cdecl Windows::Foundation::ITypedEventHandler_impl<Windows::Foundation::Internal::AggregateType<Microsoft::UI::Dispatching::DispatcherQueueTimer * __ptr64,Microsoft::UI::Dispatching::IDispatcherQueueTimer * __ptr64>,IInspectable * __ptr64>::*)(Microsoft::UI::Dispatching::IDispatcherQueueTimer * __ptr64,IInspectable * __ptr64) __ptr64>::DelegateInvokeHelper<Microsoft::WRL::Implements<Microsoft::WRL::RuntimeClassFlags<2>,Windows::Foundation::ITypedEventHandler<Microsoft::UI::Dispatching::DispatcherQueueTimer * __ptr64,IInspectable * __ptr64>,Microsoft::WRL::FtmBase>,<lambda_82cf8073f4f042d1a68771c460cb9f49>,-1,Microsoft::UI::Dispatching::IDispatcherQueueTimer * __ptr64,IInspectable * __ptr64>::Invoke+0x87

0a 000000dd0316d740 00007ff825ad84f3 CoreMessagingXP!Microsoft::WRL::InvokeTraits<-2>::InvokeDelegates<<lambda_1e854da9c9ccd42f6138c3b007a32877>,Windows::Foundation::ITypedEventHandler<Microsoft::UI::Dispatching::DispatcherQueueTimer * __ptr64,IInspectable * __ptr64> >+0x83

0b 000000dd0316d7a0 00007ff825a80b0d CoreMessagingXP!Microsoft::UI::Dispatching::DispatcherQueueTimer::TimerCallback+0xf3

0c 000000dd0316d800 00007ff825a84b66 CoreMessagingXP!CFlat::SehSafe::Execute<<lambda_a81ff790741c2a62f2197c2561f5fe49> >+0x21

0d 000000dd0316d830 00007ff825a70ea9 CoreMessagingXP!Microsoft::CoreUI::ActionCallback::ImportAdapter$+0x66

0e 000000dd0316d870 00007ff825a5c990 CoreMessagingXP!Microsoft::CoreUI::Dispatch::TimeoutManager::Callback_OnDispatch+0x1a9

0f 000000dd0316d930 00007ff825a5c6fd CoreMessagingXP!Microsoft::CoreUI::Dispatch::Dispatcher::Callback_DispatchNextItem+0x1bc

10 000000dd0316d9d0 00007ff825a4fecc CoreMessagingXP!Microsoft::CoreUI::Dispatch::Dispatcher::Callback_DispatchLoop+0x1b9

11 000000dd0316da90 00007ff825a52d72 CoreMessagingXP!Microsoft::CoreUI::Dispatch::EventLoop::Callback_RunCoreLoop+0x164

12 000000dd0316daf0 00007ff825a530e8 CoreMessagingXP!Microsoft::CoreUI::Dispatch::UserAdapter::DrainCoreMessagingQueue+0x15a

13 000000dd0316dbb0 00007ff825a937d3 CoreMessagingXP!Microsoft::CoreUI::Dispatch::UserAdapter::OnUserDispatch+0x98

14 000000dd0316dc00 00007ff825a93966 CoreMessagingXP!Microsoft::CoreUI::Dispatch::UserAdapter::DoWork+0xa7

15 000000dd0316dc60 00007ff825a93ede CoreMessagingXP!Microsoft::CoreUI::Dispatch::UserAdapter::HandleDispatchNotifyMessage+0x132

16 000000dd0316dcc0 00007ff874a08ee8 CoreMessagingXP!Microsoft::CoreUI::Dispatch::UserAdapter::WindowProc+0x5e

17 000000dd0316dcf0 00007ff874a0899c user32!UserCallWinProcCheckWow+0x4d8

18 000000dd0316de50 00007ff874a13e4d user32!DispatchClientMessage+0x9c

19 000000dd0316deb0 00007ff8769d4424 user32!_fnDWORD+0x3d

1a 000000dd0316df10 00007ff873e11504 ntdll!KiUserCallbackDispatcherContinue

1b 000000dd0316df98 00007ff874a1296f win32u!NtUserPeekMessage+0x14

1c 000000dd0316dfa0 00007ff874a1283c user32!_PeekMessage+0x3f

1d 000000dd0316e010 00007ff875bee4bb user32!PeekMessageW+0x9c

1e 000000dd0316e080 00007ff875bee425 combase!CCliModalLoop::MyPeekMessage+0x53 [onecore\com\combase\dcomrem\callctrl.cxx @ 2895]

1f 000000dd0316e0f0 00007ff875bf0aa0 combase!CCliModalLoop::PeekRPCAndDDEMessage+0x49 [onecore\com\combase\dcomrem\callctrl.cxx @ 2559]

20 000000dd0316e160 00007ff875beeec1 combase!CCliModalLoop::BlockFn+0x1ec [onecore\com\combase\dcomrem\callctrl.cxx @ 2055]

21 000000dd0316e200 00007ff875bee71f combase!ModalLoop+0xd1 [onecore\com\combase\dcomrem\chancont.cxx @ 171]

22 000000dd0316e260 00007ff875bf6e74 combase!ClassicSTAThreadDispatchCrossApartmentCall+0x5f [onecore\com\combase\dcomrem\chancont.cxx @ 324]

23 (Inline Function) --------`-------- combase!CSyncClientCall::SwitchAptAndDispatchCall+0x706 [onecore\com\combase\dcomrem\channelb.cxx @ 5691]

24 000000dd0316e2a0 00007ff875bf0d35 combase!CSyncClientCall::SendReceive2+0x824 [onecore\com\combase\dcomrem\channelb.cxx @ 5297]

25 000000dd0316e570 00007ff875bf0c9c combase!SyncClientCallRetryContext::SendReceiveWithRetry+0x51 [onecore\com\combase\dcomrem\callctrl.cxx @ 1502]

26 000000dd0316e5a0 00007ff875beeb3d combase!CSyncClientCall::SendReceiveInRetryContext+0x44 [onecore\com\combase\dcomrem\callctrl.cxx @ 582]

27 000000dd0316e5e0 00007ff875bfebec combase!ClassicSTAThreadSendReceive+0x5d [onecore\com\combase\dcomrem\callctrl.cxx @ 564]

28 000000dd0316e6f0 00007ff875bef3b8 combase!CSyncClientCall::SendReceive+0x1bc [onecore\com\combase\dcomrem\ctxchnl.cxx @ 788]

29 000000dd0316e8f0 00007ff875c7fe28 combase!CClientChannel::SendReceive+0x98 [onecore\com\combase\dcomrem\ctxchnl.cxx @ 660]

2a 000000dd0316e960 00007ff8749a050e combase!NdrExtpProxySendReceive+0x58 [onecore\com\combase\ndr\ndrole\proxy.cxx @ 1989]

2b 000000dd0316e990 00007ff875c7c36c rpcrt4!NdrpClientCall3+0x3de

2c 000000dd0316ecb0 00007ff875d06752 combase!ObjectStublessClient+0x14c [onecore\com\combase\ndr\ndrole\amd64\stblsclt.cxx @ 366]

2d 000000dd0316f040 00007ff875c51970 combase!ObjectStubless+0x42 [onecore\com\combase\ndr\ndrole\amd64\stubless.asm @ 176]

2e (Inline Function) --------`-------- combase!CClassCache::DoCrossApartmentMTAGetActivationFactory+0x167 [onecore\com\combase\objact\dllcache.cxx @ 1889]

2f 000000dd0316f090 00007ff875c501e0 combase!CClassCache::GetOrLoadWinRTInprocClass+0x5a0 [onecore\com\combase\objact\dllcache.cxx @ 4024]

30 (Inline Function) --------`-------- combase!CCGetOrLoadWinRTInprocClass+0x1f [onecore\com\combase\objact\dllcache.cxx @ 7069]

31 (Inline Function) --------`-------- combase!WinRTGetActivationFactoryOfInprocClass+0x4e [onecore\com\combase\objact\objact.cxx @ 2227]

32 000000dd0316f250 00007ff875c4fd2e combase!_RoGetActivationFactory+0x490 [onecore\com\combase\winrtbase\winrtbase.cpp @ 1002]

33 000000dd0316f660 00007fff9fed9a9a combase!RoGetActivationFactory+0xae [onecore\com\combase\winrtbase\winrtbase.cpp @ 1111]

34 (Inline Function) --------`-------- Microsoft_ui_xaml!ABI::Windows::Foundation::GetActivationFactory+0x14 [C:__w\1\s\packages\Microsoft.Windows.SDK.cpp.10.0.22621.755\c\Include\10.0.22621.0\winrt\roapi.h @ 282]

35 (Inline Function) --------`-------- Microsoft_ui_xaml!ABI::Windows::Foundation::GetActivationFactory+0x1d [C:__w\1\s\packages\Microsoft.Windows.SDK.cpp.10.0.22621.755\c\Include\10.0.22621.0\winrt\wrl\client.h @ 968]

36 000000dd0316f6a0 00007fff9fed9480 Microsoft_ui_xaml!ApplicationDataProvider::GetStateFolderUris+0x76 [C:__w\1\s\dxaml\xcp\plat\win\desktop\ApplicationDataProvider.cpp @ 199]

37 (Inline Function) --------`-------- Microsoft_ui_xaml!ApplicationDataProvider::Initialize+0x11 [C:__w\1\s\dxaml\xcp\plat\win\desktop\ApplicationDataProvider.cpp @ 149]

38 000000dd0316f760 00007fff9fed21fd Microsoft_ui_xaml!ApplicationDataProvider::Create+0x74 [C:__w\1\s\dxaml\xcp\plat\win\desktop\ApplicationDataProvider.cpp @ 30]

39 000000dd0316f790 00007fffa0380c46 Microsoft_ui_xaml!CWindowsServices::CreateApplicationDataProvider+0x1d [C:__w\1\s\dxaml\xcp\plat\win\desktop\PlatformServices.cpp @ 79]

3a 000000dd0316f7c0 00007fff9fd3bac1 Microsoft_ui_xaml!ResourceManager::GetAppDataProviderNoRef+0x36 [C:__w\1\s\dxaml\xcp\control\common\shared\ResourceManager.cpp @ 56]

3b 000000dd0316f7f0 00007fff9fe5b6fa Microsoft_ui_xaml!ResourceManager::TryGetLocalResource+0x2364e1 [C:__w\1\s\dxaml\xcp\control\common\shared\ResourceManager.cpp @ 127]

3c 000000dd0316f860 00007fff9fe5b524 Microsoft_ui_xaml!PALFontAndScriptServices::GetResource+0x96 [C:__w\1\s\dxaml\xcp\core\text\richtextservices\xcp\PALFontAndScriptServices.cpp @ 340]

3d 000000dd0316f8e0 00007fff9fd7f675 Microsoft_ui_xaml!PALFontAndScriptServices::CreateFontCollectionFromUri+0xe4 [C:__w\1\s\dxaml\xcp\core\text\richtextservices\xcp\PALFontAndScriptServices.cpp @ 374]

3e 000000dd0316fa70 00007fff9fbaa3ce Microsoft_ui_xaml!CCompositeFontFamily::CreateNew+0x1d65c1 [C:__w\1\s\dxaml\xcp\core\text\fonts\compositefontfamily.cpp @ 599]

3f 000000dd0316fb80 00007fff9faa4aec Microsoft_ui_xaml!CTypefaceCollection::LookupCompositeFontFamily+0xbe [C:__w\1\s\dxaml\xcp\core\text\fonts\typefacecollection.cpp @ 88]

40 000000dd0316fc20 00007fff9faa37b2 Microsoft_ui_xaml!CFontFamily::EnsureCompositeFontFamily+0xac [C:__w\1\s\dxaml\xcp\core\text\fonts\fontfamily.cpp @ 107]

41 (Inline Function) --------`-------- Microsoft_ui_xaml!CFontFamily::GetTextLineBoundsMetrics+0x17 [C:__w\1\s\dxaml\xcp\core\text\fonts\fontfamily.cpp @ 72]

42 000000dd0316fc60 00007fff9fa490eb Microsoft_ui_xaml!CTextBlock::GetLineHeight+0x192 [C:__w\1\s\dxaml\xcp\core\text\textblock\textblock.cpp @ 1536]

43 000000dd0316fd50 00007fff9f9dfa74 Microsoft_ui_xaml!CTextBlock::MeasureOverride+0xbb [C:__w\1\s\dxaml\xcp\core\text\textblock\textblock.cpp @ 1611]

44 000000dd0316fea0 00007fff9fb63a4c Microsoft_ui_xaml!CFrameworkElement::MeasureCore+0x2a4 [C:__w\1\s\dxaml\xcp\core\core\elements\framework.cpp @ 1598]

45 000000dd0316ffd0 00007fff9f9e1535 Microsoft_ui_xaml!CUIElement::MeasureInternal+0x6ac [C:__w\1\s\dxaml\xcp\core\core\elements\uielement.cpp @ 4119]

46 000000dd03170110 00007fff9fa00e9c Microsoft_ui_xaml!CUIElement::Measure+0x525 [C:__w\1\s\dxaml\xcp\core\core\elements\uielement.cpp @ 3954]

47 000000dd031701d0 00007fff9fa17af9 Microsoft_ui_xaml!CGrid::MeasureOverride+0x11c [C:__w\1\s\dxaml\xcp\core\core\elements\grid.cpp @ 1005]

48 (Inline Function) --------`-------- Microsoft_ui_xaml!CFrameworkElement::MeasureOverrideForPInvoke+0x2e [C:__w\1\s\dxaml\xcp\core\core\elements\framework.cpp @ 1429]

49 (Inline Function) --------`-------- Microsoft_ui_xaml!CoreImports::FrameworkElement_MeasureOverride+0x37 [C:__w\1\s\dxaml\xcp\core\dll\CoreImports.cpp @ 546]

4a (Inline Function) --------`-------- Microsoft_ui_xaml!DirectUI::FrameworkElement::MeasureOverrideImpl+0x4b [C:__w\1\s\dxaml\xcp\dxaml\lib\FrameworkElement_Partial.cpp @ 203]

4b 000000dd03170420 00007fff49c68c75 Microsoft_ui_xaml!DirectUI::FrameworkElementGenerated::MeasureOverride+0xc9 [C:__w\1\s\dxaml\xcp\dxaml\lib\winrtgeneratedclasses\FrameworkElement.g.cpp @ 1068]

Steps to reproduce the bug

I don't have a full set of repro steps, but per conversation with @codendone ApplicationDataProvider::GetStateFolderUris tries to create a Windows_Storage_ApplicationData object which allows for re-entrancy.

Expected behavior

No response

Screenshots

No response

NuGet package version

None

Windows version

No response

Additional context

No response