-
Notifications
You must be signed in to change notification settings - Fork 334
Open
Labels
Description
Describe the bug
Some typekits (at least model.create and modelProperty.create from my testing) return unfinished types.
Very bad and difficult to debug things can happen if you forget to finish the Type yourself with program.finishType: unfinished types can be passed back into the checker resulting in decorators not running, etc. because the checker believes the types aren't done, but they will never be done unless you manually call finishType.
This has bitten me several times. TKs should always return fully checked (finished) instances.
Reproduction
$(program).modelProperty.create({
name: "foo",
type: $(program).builtin.string
}).isFinished;
// falseChecklist
- Follow our Code of Conduct
- Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
- Check that this is a concrete bug. For Q&A open a GitHub Discussion.
- The provided reproduction is a minimal reproducible example of the bug.