Time to address the elephant in the room: There are too few users with PR merging rights who merge PRs. #333858
Replies: 3 comments 10 replies
-
|
We're at an inflection point in terms of the number of PRs being submitted and the ability for the infrastructure to gracefully handle the load of automated validation. We have some large changes in progress: The project gives a view of items currently deemed "important" to work on next. I've had to make some tough calls relative to the number of Microsoft folks who have PR merge rights and should focus on manual reviews vs. improving the infrastructure. Right now, I'm optimizing for getting these big changes implemented and released. I see this issue as more of a "call to action" or a "discussion" as opposed to a feature or bug to be implemented. I'm going to go ahead and convert it to a discussion. |
Beta Was this translation helpful? Give feedback.
-
|
Most of our "moderators" are community members. They have the ability to "moderator approve" PRs that have passed the automated validation steps. They don't necessarily have all the insights into what went wrong when something doesn't just flow through the system. There is only so much they can do, and they are volunteering their valuable time and knowledge. Handling the exceptional cases (I think of these often as "known classes of problems") often requires someone from Microsoft to review. These are where the most time is consumed for people working on the project. The following Issue has a list of known classes of problems: We see those as areas where it takes more "human" time that generally extend the average time from PR submitted until the package version has been published. We will be prioritizing the ones that have the biggest impact in terms of the amount of time that class of problem impacts our overall throughput. We've been doing a lot of work behind the scenes to improve visibility for what went "wrong" or why a PR "failed" automated validation. When we have our next big release with the GitHub App and a few other improvements in progress (like queueing) we're expecting to reduce the time it takes to investigate. It should also surface more information directly on the PR in the form of comments as opposed to requiring someone to go spelunking in log files. |
Beta Was this translation helpful? Give feedback.
-
|
Just thinking out loud. I like winget. I think it's one of those things MSFT is still mostly doing right (compared to a lot of other divisions I could roast). However, the key thing I see here is a staffing ($$$) issue. Microsoft isn't committing the resources to winget which is an incredibly important project to holding up the broader security of the entire Windows platform. Microsoft, via winget, helps developers keep their software deployed to end user machines faster with the least amount of trouble. What's the security cost of NOT getting third-party vulnerabilities on Windows patched? Why is Microsoft not investing in the staff? Wouldn't staffing this project appropriately directly support a "secure by default" mission? Sounds to me like there is a direct parallel between this discussion and the very origins of Winget. Microsoft is cutting corners. |
Beta Was this translation helpful? Give feedback.


Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
#333536 makes me think the time is right.
Essentially:
Validation-Completedtags.Validation-No-Executablesis the most severe example (with# 329209elaborating partially on it).# 332112.# 329263and# 333533).The 2 possible solutions are the same as in similar cases throughout GitHub where PR backlogs have got out of control:
Beta Was this translation helpful? Give feedback.
All reactions