Merge pull request #677 from microting/copilot/fix-warnings-in-codebase

Remove obsolete EF Core methods and fix non-nullable property warnings

Author: renemadsen

eFormAPI/Plugins/BackendConfiguration.Pn/BackendConfiguration.Pn.Integration.Test/TestBaseSetup.cs

@@ -40,7 +40,6 @@ private BackendConfigurationPnDbContext GetBackendDbContext(string connectionStr
                 ServerVersion.AutoDetect(connectionStr)),
             mySqlOptionsAction: builder => {
                 builder.EnableRetryOnFailure();
-                builder.TranslateParameterizedCollectionsToConstants();
             });
 
         var backendConfigurationPnDbContext = new BackendConfigurationPnDbContext(optionsBuilder.Options);
@@ -71,7 +70,6 @@ private ItemsPlanningPnDbContext GetItemsPlanningPnDbContext(string connectionSt
                 ServerVersion.AutoDetect(connectionStr)),
             mySqlOptionsAction: builder => {
                 builder.EnableRetryOnFailure();
-                builder.TranslateParameterizedCollectionsToConstants();
             });
 
         var backendConfigurationPnDbContext = new ItemsPlanningPnDbContext(optionsBuilder.Options);
@@ -94,7 +92,6 @@ private TimePlanningPnDbContext GetTimePlanningPnDbContext(string connectionStr)
                 ServerVersion.AutoDetect(connectionStr)),
             mySqlOptionsAction: builder => {
                 builder.EnableRetryOnFailure();
-                builder.TranslateParameterizedCollectionsToConstants();
             });
 
         var backendConfigurationPnDbContext = new TimePlanningPnDbContext(optionsBuilder.Options);
@@ -117,7 +114,6 @@ private CaseTemplatePnDbContext GetCaseTemplatePnDbContext(string connectionStr)
                 ServerVersion.AutoDetect(connectionStr)),
             mySqlOptionsAction: builder => {
                 builder.EnableRetryOnFailure();
-                builder.TranslateParameterizedCollectionsToConstants();
             });
 
         var backendConfigurationPnDbContext = new CaseTemplatePnDbContext(optionsBuilder.Options);
@@ -139,7 +135,6 @@ private MicrotingDbContext GetContext(string connectionStr)
                 ServerVersion.AutoDetect(connectionStr)),
             mySqlOptionsAction: builder => {
                 builder.EnableRetryOnFailure();
-                builder.TranslateParameterizedCollectionsToConstants();
             });
         var microtingDbContext = new MicrotingDbContext(dbContextOptionsBuilder.Options);
         var file = Path.Combine("SQL", "420_SDK.sql");
@@ -160,7 +155,6 @@ private BaseDbContext GetBaseDbContext(string connectionStr)
                 ServerVersion.AutoDetect(connectionStr)),
             mySqlOptionsAction: builder => {
                 builder.EnableRetryOnFailure();
-                builder.TranslateParameterizedCollectionsToConstants();
             });
         var baseDbContext = new BaseDbContext(optionsBuilder.Options);
         // var file = Path.Combine("SQL", "420_SDK.sql");

eFormAPI/Plugins/BackendConfiguration.Pn/BackendConfiguration.Pn/EformBackendConfigurationPlugin.cs

@@ -673,7 +673,6 @@ public void ConfigureDbContext(IServiceCollection services, string connectionStr
             {
                 builder.EnableRetryOnFailure();
                 builder.MigrationsAssembly(PluginAssembly().FullName);
-                builder.TranslateParameterizedCollectionsToConstants();
             }));
 
         services.AddDbContext<ItemsPlanningPnDbContext>(o =>
@@ -682,7 +681,6 @@ public void ConfigureDbContext(IServiceCollection services, string connectionStr
             {
                 builder.EnableRetryOnFailure();
                 builder.MigrationsAssembly(PluginAssembly().FullName);
-                builder.TranslateParameterizedCollectionsToConstants();
             }));
 
         services.AddDbContext<TimePlanningPnDbContext>(o =>
@@ -691,7 +689,6 @@ public void ConfigureDbContext(IServiceCollection services, string connectionStr
             {
                 builder.EnableRetryOnFailure();
                 builder.MigrationsAssembly(PluginAssembly().FullName);
-                builder.TranslateParameterizedCollectionsToConstants();
             }));
 
         services.AddDbContext<ChemicalsDbContext>(o =>
@@ -700,7 +697,6 @@ public void ConfigureDbContext(IServiceCollection services, string connectionStr
             {
                 builder.EnableRetryOnFailure();
                 builder.MigrationsAssembly(PluginAssembly().FullName);
-                builder.TranslateParameterizedCollectionsToConstants();
             }));
 
         services.AddDbContext<CaseTemplatePnDbContext>(o =>
@@ -709,7 +705,6 @@ public void ConfigureDbContext(IServiceCollection services, string connectionStr
             {
                 builder.EnableRetryOnFailure();
                 builder.MigrationsAssembly(PluginAssembly().FullName);
-                builder.TranslateParameterizedCollectionsToConstants();
             }));
 
         services.AddDbContext<BaseDbContext>(
@@ -718,7 +713,6 @@ public void ConfigureDbContext(IServiceCollection services, string connectionStr
             {
                 builder.EnableRetryOnFailure();
                 builder.MigrationsAssembly(PluginAssembly().FullName);
-                builder.TranslateParameterizedCollectionsToConstants();
             }));
 
         var chemicalsContextFactory = new ChemicalsContextFactory();

eFormAPI/Plugins/BackendConfiguration.Pn/BackendConfiguration.Pn/Infrastructure/Models/TaskWizard/TaskWizardModel.cs

@@ -9,11 +9,11 @@ namespace BackendConfiguration.Pn.Infrastructure.Models.TaskWizard;
 public class TaskWizardModel
 {
     public int Id { get; set; }
-    public string Property { get; set; }
-    public string Folder { get; set; }
+    public required string Property { get; set; }
+    public required string Folder { get; set; }
     public List<CommonTagModel> Tags { get; set; } = [];
-    public string TaskName { get; set; }
-    public string Eform { get; set; }
+    public required string TaskName { get; set; }
+    public required string Eform { get; set; }
     public DateTime StartDate { get; set; }
     public RepeatType RepeatType { get; set; }
     public int RepeatEvery { get; set; }