unit tests

Author: miguelgrinberg

tests/async/test_pubsub_manager.py

@@ -5,8 +5,10 @@
 
 import pytest
 
+from engineio.packet import Packet as EIOPacket
 from socketio import async_manager
 from socketio import async_pubsub_manager
+from socketio import async_server
 from socketio import packet
 
 
@@ -846,3 +848,14 @@ async def messages():
         self.pm._handle_emit.assert_awaited_with(
             {'method': 'emit', 'value': 'bar', 'host_id': 'x'}
         )
+
+    def test_custom_json(self):
+        saved_json = packet.Packet.json
+
+        cm = async_pubsub_manager.AsyncPubSubManager(json='foo')
+        assert cm.json == 'foo'
+        async_server.AsyncServer(json='bar', client_manager=cm)
+        assert cm.json == 'bar'
+
+        packet.Packet.json = saved_json
+        EIOPacket.json = saved_json

tests/async/test_redis_manager.py

@@ -2,8 +2,10 @@
 import redis
 import valkey
 
-from socketio import async_redis_manager
+from engineio.packet import Packet as EIOPacket
+from socketio import async_redis_manager, AsyncServer
 from socketio.async_redis_manager import AsyncRedisManager
+from socketio.packet import Packet
 
 
 class TestAsyncRedisManager:
@@ -109,3 +111,14 @@ def test_valkey_connect(self):
             assert isinstance(c.redis, valkey.asyncio.Valkey)
 
         async_redis_manager.aioredis = saved_redis
+
+    def test_custom_json(self):
+        saved_json = Packet.json
+
+        cm = AsyncRedisManager('redis://', json='foo')
+        assert cm.json == 'foo'
+        AsyncServer(json='bar', client_manager=cm)
+        assert cm.json == 'bar'
+
+        Packet.json = saved_json
+        EIOPacket.json = saved_json

tests/common/test_pubsub_manager.py

@@ -5,9 +5,11 @@
 
 import pytest
 
+from engineio.packet import Packet as EIOPacket
 from socketio import manager
 from socketio import pubsub_manager
 from socketio import packet
+from socketio import server
 
 
 class TestPubSubManager:
@@ -822,3 +824,14 @@ def messages():
         self.pm._handle_emit.assert_called_with(
             {'method': 'emit', 'value': 'bar', 'host_id': 'x'}
         )
+
+    def test_custom_json(self):
+        saved_json = packet.Packet.json
+
+        cm = pubsub_manager.PubSubManager(json='foo')
+        assert cm.json == 'foo'
+        server.Server(json='bar', client_manager=cm)
+        assert cm.json == 'bar'
+
+        packet.Packet.json = saved_json
+        EIOPacket.json = saved_json

tests/common/test_redis_manager.py

@@ -2,7 +2,9 @@
 import redis
 import valkey
 
-from socketio import redis_manager
+from engineio.packet import Packet as EIOPacket
+from socketio import redis_manager, Server
+from socketio.packet import Packet
 from socketio.redis_manager import RedisManager, parse_redis_sentinel_url
 
 
@@ -144,3 +146,14 @@ def test_sentinel_url_parser(self, rtype):
             'myredis',
             {'username': 'user', 'password': 'password', 'db': 0}
         )
+
+    def test_custom_json(self):
+        saved_json = Packet.json
+
+        cm = RedisManager('redis://', json='foo')
+        assert cm.json == 'foo'
+        Server(json='bar', client_manager=cm)
+        assert cm.json == 'bar'
+
+        Packet.json = saved_json
+        EIOPacket.json = saved_json

tox.ini

@@ -14,7 +14,7 @@ python =
 [testenv]
 commands=
     pip install -e .
-    pytest -p no:logging --timeout=60 --cov=socketio --cov-branch --cov-report=term-missing --cov-report=xml
+    pytest -p no:logging --timeout=60 --cov=socketio --cov-branch --cov-report=term-missing --cov-report=xml {posargs}
 deps=
     simple-websocket
     uvicorn