Skip to content

Regression with miniz_oxide>0.8.5 #211

@musicinmybrain

Description

@musicinmybrain
$ git clone https://github.com/milesgranger/cramjam.git
$ cd cramjam
$ uv venv _e
$ . _e/bin/activate
(_e) $ uv pip install -e .[dev]
(_e) $ python -m pytest --ignore=benchmarks/test_bench.py -n auto
[…]
=================================== 742 passed, 1 skipped in 4.96s ===================================
(_e) $ cargo update miniz_oxide
    Updating crates.io index
     Locking 1 package to latest compatible version
    Updating miniz_oxide v0.8.5 -> v0.8.8
note: pass `--verbose` to see 41 unchanged dependencies behind latest
(_e) $ uv pip install -e .[dev]
(_e) $ python -m pytest --ignore=benchmarks/test_bench.py -n auto
[…]
============================================== FAILURES ==============================================
_______________________________ test_variants_raise_exception[deflate] _______________________________
[gw5] linux -- Python 3.13.3 /home/ben/src/forks/cramjam/_e/bin/python

variant_str = 'deflate'

    @pytest.mark.parametrize("variant_str", VARIANTS)
    def test_variants_raise_exception(variant_str):
        variant = getattr(cramjam, variant_str)
>       with pytest.raises(cramjam.DecompressionError):
E       Failed: DID NOT RAISE <class 'cramjam.DecompressionError'>

tests/test_variants.py:96: Failed
====================================== short test summary info =======================================
FAILED tests/test_variants.py::test_variants_raise_exception[deflate] - Failed: DID NOT RAISE <class 'cramjam.DecompressionError'>
============================== 1 failed, 741 passed, 1 skipped in 4.30s ==============================

I tried cargo update miniz_oxide --precise 0.8.7, rebuilt, ran tests again, and still reproduced the issue, then again for the yanked 0.8.6 release, so this was introduced after 0.8.5.

https://github.com/Frommi/miniz_oxide/blob/master/CHANGELOG.md#087---2025-04-03

It’s not immediately obvious to me how to investigate this further.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions