Skip to content

Crate depends on unix methods - does not compile on windows #13

@ghost

Description

This crate seems to only support unix, and relies on several unix-only methods from the stdlib, such as std::os::unix::ffi::{OsStrExt, DirBuilderExt, MetadataExt, OpenOptionsExt} and many more within localfs.rs.

Furthermore it seems to be relying on the runtime provided "case insensitive" flag to switch between windows and unix parts of the library, which is both unintuitive, and easily replacable with conditional compilation.

The correct behaviour should be to use the platform-independent methods as much as possible (for example replacing unix modes to open files with a rust file builder), then when necessary conditionally compile either unix or windows methods based on the compile target, or explicitly and clearly state that windows is not supported.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions