improve usability of White Noise effect

[ronso0]

Bug Description

The White Noise effect is currently the only Mixxx effect that is a signal generator, not a modulator and the handling feels kind of unintuitive:

• effects are applied post-fader, hence White Noise can only be regulated with the Dry/Wet knob
• it's activated only if a track is loaded to affected players

It would be nice if it was possible to create White Noise -> Echo effects with the Volume fader like in this example
JAMES HYPE "NOISE" SECRET TRICK using Pioneer DDJ-400

https://mixxx.discourse.group/t/white-noise-effect-in-2-4/27891

Version

No response

OS

No response

[vespadj]

We could insert a "Gain" knob, to limit the maximum value.
Even better if the signal was multiplied by the value of the channel slider (can this be done?).

We should insert a control that below a certain threshold, the function returns to silence, because by turning the controller, in the zero position, a slight noise is heard (0 --> 0.00xxx some digits --> residual noise).
Notes: 1.0 / 127 = 0.007874
if (x < 0.0078) { return silence}

[daschuer]

Hi @vespadj this looks like a ideal first contribution, even without a deep C++ knowledge. Do you have interest to pick this up.
On which OS are you. Will you be able to build Mixxx from source? Do you need help?
https://github.com/mixxxdj/mixxx/wiki/Bugfix-Workflow

[vespadj]

Hi @daschuer, in #2921 I ask to developers to look this thread.
For some suggestions from creators.

I tried to create an effect, https://mixxx.discourse.group/t/fx-reverbed-fade/29397/9, but C++ is very hard for me, heavy experience without satisfaction nor results :-| :-)

[aneeshwath]

Hey @ronso0 , @daschuer and @vespadj ! I am ready to take up this issue. I set up the codebase environment, but I am a little bit confused about how to make the White Noise Effect Intuitive and more effective. Please mention your expectations and ideas so that I can work on it. This issue seems to be quite untouched for a long time.

[vespadj]

Hi @aneeshwath , my first step was, insert a gain knob and apply silence under 0.0078 (see up).
As second step, the signal could be filter by <20 Hz and >20'000 Hz, but it's not necessary at all.
I noticed these aspects after play with this chain effects, if you will try, also take a look to VU Meter, that it goes to full with non-audible frequencies.

[aneeshwath]

Sorry for the late update, but I’ve been actively working on this issue. Here's what I’ve accomplished so far:

• Added a Gain (Gain knob) parameter
• Applied silence under 0.0078
• Implemented filtered white noise using high-pass and low-pass biquad filters (cutting frequencies below 20 Hz and above 20,000 Hz)
• Mapped the Meta knob to control only Dry/Wet, not Gain

@vespadj If you spot anything that could be improved or if my approach seems off, I’d really appreciate your suggestions!

Pending Objective: Channel fader modulation is currently on hold.
I'd love some guidance here — @ronso0 , do you have any insights on how I might access and use the channel fader inside whitenoiseeffect?

[Swiftb0y]

do you have any insights on how I might access and use the channel fader inside whitenoiseeffect?

You can't easily and you shouldn't because that will make the interface very confusing IMO.

Additionally, in order to speed up performance, the generation of the white noise as well as and processing (your low- and high-pass filters) should be done in advance (use an audio editor or DAW of your choie). In the end, the whitenoise filter can be implemented simply by taking the whitenoise signal and playing it back seamlessly (similar to the metronome effect, but simpler since there doesn't need to be any timing code).

[aneeshwath]

do you have any insights on how I might access and use the channel fader inside whitenoiseeffect?

You can't easily and you shouldn't because that will make the interface very confusing IMO.

I was considering doing it; as expected by @ronso0 ...

It would be nice if it was possible to create White Noise -> Echo effects with the **Volume fader like in this example
JAMES HYPE "NOISE" SECRET TRICK using Pioneer DDJ-400

Video link referenced as in discourse discussion : https://www.youtube.com/shorts/MtowEW64JZk

@Swiftb0y Other things are already implemented and working fine as expected by you.

[Swiftb0y]

Is there a PR or branch to look at?

[aneeshwath]

Check out the implementation of White Noise Effect: #2921
After that go through this open issue discussion again to understand the requirements and my approach.

I'm working on making the White Noise effect more intuitive and effective, based on the requirements outlined in this open issue. Once all requirements are addressed and implemented, I’ll open a dedicated PR to resolve this issue(Only one requirement is pending). As mentioned before I am asking for help to figure out : How can I use Volume Fader in the white noise effect to get the output as shown in reference video.

[Swiftb0y]

Check out the implementation of White Noise Effect: #2921
After that go through this open issue discussion again to understand the requirements and my approach.

I have done both previously. I'm asking you to show me some actual code to evaluate!

How can I use Volume Fader in the white noise effect to get the output as shown in reference video.

You can't without significant changes to the processing order of effects! Ignore that requirement for now.